From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#53164: (After an ELC+ELN build, don't load the source file into a buffer.) fixed. Date: Tue, 11 Jan 2022 18:03:14 +0000 Message-ID: References: <83v8yr8o0t.fsf@gnu.org> <83ilur8j0f.fsf@gnu.org> <83bl0i8nkt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53164@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 11 19:14:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7Ler-0002Gq-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 19:14:09 +0100 Original-Received: from localhost ([::1]:42996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7Leq-0006zH-3M for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 13:14:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7LV4-0004NK-SH for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7LV4-0007pb-Hk for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7LV4-0002PR-Bk for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2022 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53164 X-GNU-PR-Package: emacs Original-Received: via spool by 53164-submit@debbugs.gnu.org id=B53164.16419242059159 (code B ref 53164); Tue, 11 Jan 2022 18:04:02 +0000 Original-Received: (at 53164) by debbugs.gnu.org; 11 Jan 2022 18:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:55500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7LUS-0002Nd-KM for submit@debbugs.gnu.org; Tue, 11 Jan 2022 13:03:25 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:58920 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1n7LUO-0002N6-Sa for 53164@debbugs.gnu.org; Tue, 11 Jan 2022 13:03:22 -0500 Original-Received: (qmail 72016 invoked by uid 3782); 11 Jan 2022 18:03:14 -0000 Original-Received: from acm.muc.de (p4fe1582c.dip0.t-ipconnect.de [79.225.88.44]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 11 Jan 2022 19:03:14 +0100 Original-Received: (qmail 30528 invoked by uid 1000); 11 Jan 2022 18:03:14 -0000 Content-Disposition: inline In-Reply-To: <83bl0i8nkt.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223952 Archived-At: Hello, Eli. On Tue, Jan 11, 2022 at 14:27:14 +0200, Eli Zaretskii wrote: > > Date: Mon, 10 Jan 2022 20:21:40 +0000 > > Cc: 53164@debbugs.gnu.org, acm@muc.de > > From: Alan Mackenzie > > > After reading this, I still don't understand how come you bump into > > > this problem, whereas I don't, and neither does anyone else who builds > > > the release branch with native-compilation. Is this something > > > specific to that branch you are working on? > > Indeed, yes. It is the symbols with position which escaped from a > > compiler macro. > > > If so, why is it urgent to have the fix on the release branch? The > > > branch on which you ware working will land on master. > > There was no urgency. I though the convention was for documentation > > fixes and simple safe code fixes to go onto the release branch. The fix > > to this bug, a single line, is well understood and certainly comes into > > the category of simple and safe. > The fix is well understood, but its possible effects aren't. OK, we will just have to disagree on this point. If I wasn't sure about the lack of possible negative effects, I wouldn't have committed the fix to the emacs-28 branch. > We have been using the current code for more than a year with no > problems whatsoever. None on the emacs-28 branch, perhaps. I had severe problems with the same code on a branch branched from master. Incidentally, I timed a bootstrap on the release branch with and without the fix, both starting from a warm file cache. With the fix, the build ran ~7% faster. > > > There's always one more bug. When we are so far into the pretest > > > process, problems that take unusual steps to reproduce are not > > > important enough to delay the release. > > OK. But can I ask you to consider announcing on emacs-devel when the > > criteria for making bug fixes on the release branch change? Apologies if > > you have done, and I missed it. > This is in CONTRIBUTE: > If you are fixing a bug that exists in the current release, you should > generally commit it to the release branch; it will be merged to the > master branch later by the gitmerge function. However, when the > release branch is for Emacs version NN.2 and later, or when it is for > Emacs version NN.1 that is in the very last stages of its pretest, > that branch is considered to be in a feature freeze: only bug fixes > that are "safe" or are fixing major problems should go to the release > branch, the rest should be committed to the master branch. This is so > to avoid destabilizing the next Emacs release. If you are unsure > whether your bug fix is "safe" enough for the release branch, ask on > the emacs-devel mailing list. OK, thanks. I'm not sure I understand any more what "safe" means in this context. > > There're three ways we could go. Commit it in emacs-28, master, or > > scratch/correct-warning-pos. I'm willing to commit it again in any of > > these places. > Please install this on master (or leave it on your branch), and we > will revisit this when time comes for Emacs 28.2. I'll install it on master this evening. Thanks! > Thanks. -- Alan Mackenzie (Nuremberg, Germany).