bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Thu, Dec 23, 2021 at 01:19:34PM -0500, Aaron Jensen wrote:
> On Thu, Dec 23, 2021 at 11:09 AM Alan Third <alan@idiocy.org> wrote:
> > Looks like we can set hasShadow to NO. Maybe we want to do that to
> > undecorated child frames, or something?
> 
> That's probably reasonable. I like it for emacs-mini-frame, but having
> the shadows on company posframe is silly, so I'm fine not having it
> for anything.

Please try the attached, it's completely untested.
-- 
Alan Third

[-- Attachment #2: 0001-Remove-macOS-drop-shadows-on-some-frames-bug-28512.patch --]
[-- Type: text/x-diff, Size: 1019 bytes --]

From 0b9c068ae1186b0831495d82f5a7199da5f8401a Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Tue, 28 Dec 2021 11:36:46 +0000
Subject: [PATCH] Remove macOS drop-shadows on some frames (bug#28512)

* src/nsterm.m ([EmacsWindow setParentChildRelationships]): Remove
shadows on undecorated child frames.
---
 src/nsterm.m | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/nsterm.m b/src/nsterm.m
index f79e271a98..6178dd80bb 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8435,6 +8435,15 @@ - (void)setParentChildRelationships
 #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1070
   [ourView updateCollectionBehavior];
 #endif
+
+  /* Child frames are often used in ways that may mean they should
+     "disappear" into the contents of the parent frame.  macOs's
+     drop-shadows break this effect, so remove them on undecorated
+     child frames.  */
+  if (parentFrame && FRAME_UNDECORATED (ourFrame))
+    [self setHasShadow:NO];
+  else
+    [self setHasShadow:YES];
 #endif
 
 
-- 
2.33.0