From: Alan Third <alan@idiocy.org>
To: tsuucat <tsuucat@icloud.com>, 50160@debbugs.gnu.org
Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Wed, 22 Dec 2021 20:50:42 +0000 [thread overview]
Message-ID: <YcOPopvLRKS2uqnD@idiocy.org> (raw)
In-Reply-To: <YTp1sD4N16MEEZb7@idiocy.org>
On Thu, Sep 09, 2021 at 09:59:28PM +0100, Alan Third wrote:
> On Fri, Sep 10, 2021 at 02:33:40AM +0900, tsuucat wrote:
> >
> > > Ah, hmm... Perhaps we should append the label text to the hash or
> > > something?
> >
> > I tried to append the label text to the hash. Most items fixed. But
> > isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item
> > so the tool-tip is wrong…
> > It is hard to set correct identifier because anyone can create toolbar items
> > dynamically in Emacs lisp.
> >
> > I noticed the current toolbaritem problem only matters label and tool-tip.
> > Executed commands are not wrong.
>
> I suppose we could concatenate the hashes of all the values that might
> matter.
I've pushed a change to master that (I hope) does this.
--
Alan Third
next prev parent reply other threads:[~2021-12-22 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 2:32 bug#50160: 28.0.50; Wrong NSToolbarItem identifier tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 20:09 ` Alan Third
2021-09-09 17:33 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 20:59 ` Alan Third
2021-12-22 20:50 ` Alan Third [this message]
2022-08-22 13:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcOPopvLRKS2uqnD@idiocy.org \
--to=alan@idiocy.org \
--cc=50160@debbugs.gnu.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.