all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52298@debbugs.gnu.org
Subject: bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode
Date: Sun, 12 Dec 2021 19:05:45 +0000	[thread overview]
Message-ID: <YbZICVAERUG3EFXZ@ACM> (raw)
In-Reply-To: <837dcap4jt.fsf@gnu.org>

Hello, Eli.

On Sun, Dec 12, 2021 at 11:15:34 +0200, Eli Zaretskii wrote:
> > Date: Sun, 12 Dec 2021 08:58:08 +0000
> > Cc: 52298@debbugs.gnu.org, acm@muc.de
> > From: Alan Mackenzie <acm@muc.de>

> > > > So, I suggest I write a commit message and commit that patch.

> > > Which patch?  I'm afraid I'm missing something here.

> > This one, the one that should prevent excessive incursions into the
> > redisplay engine when a text property gets set whilst
> > inhibit-modification-hooks is set:

> No, this cannot be used as-is, because when face properties change, we
> do want redisplay to take notice, of course.  I guess that's why
> inhibit-modification-hooks doesn't prevent incrementing the
> modification tick when text properties are changed in the first place:
> it's not feasible to know which text properties affect the display and
> which don't.  No one expected text properties irrelevant to display to
> be put on buffer text with such high frequency.

Yes, that makes sense, thanks.  Maybe I'll put a comment in there saying
that.

> If you don't have any other ideas, I guess we will have to live with
> this.  Too bad.

> (Sorry, but I like CC Mode less and less with every Emacs release, due
> to changes like this one.)

This particular feature simply hasn't worked out well.  If the
background scanning were to complete in a few seconds, it wouldn't be
too bad.  But nearly two minutes on a modern (well, 4½ yo) machine for
just one buffer, with the annoyance of the "stuttering", is not worth
the gain.

What we have is effectively the entire buffer getting half-fontified in
the background.  That's not what JIT fontification is supposed to be
about.

So, in the next few days sometime, I will revert most of this change.  A
useful and harmless piece of it (fontifying a newly found type
throughout the buffer when it is encountered in "normal" jit
fontification), I plan to leave in.  That will get rid of that timer and
all the background scanning it triggered.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2021-12-12 19:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05  7:46 bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode Eli Zaretskii
2021-12-06 20:53 ` Alan Mackenzie
2021-12-07 12:58   ` Eli Zaretskii
2021-12-07 19:58     ` Alan Mackenzie
2021-12-07 20:16       ` Eli Zaretskii
2021-12-08 20:15 ` Alan Mackenzie
2021-12-09  7:08   ` Eli Zaretskii
2021-12-09 20:11     ` Alan Mackenzie
2021-12-09 20:38       ` Eli Zaretskii
2021-12-10 18:16         ` Alan Mackenzie
2021-12-10 18:51           ` Eli Zaretskii
2021-12-10 22:52             ` Alan Mackenzie
2021-12-11  7:59               ` Eli Zaretskii
2021-12-11 14:52                 ` Alan Mackenzie
2021-12-11 15:38                   ` Eli Zaretskii
2021-12-11 17:04                     ` Alan Mackenzie
2021-12-11 18:21                       ` Eli Zaretskii
2021-12-12  8:58                         ` Alan Mackenzie
2021-12-12  9:15                           ` Eli Zaretskii
2021-12-12 19:05                             ` Alan Mackenzie [this message]
2021-12-12 19:21                               ` Eli Zaretskii
2021-12-13 14:19                                 ` Alan Mackenzie
2021-12-12 23:31                               ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-13 14:25                                 ` Alan Mackenzie
2021-12-19 14:38                               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbZICVAERUG3EFXZ@ACM \
    --to=acm@muc.de \
    --cc=52298@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.