From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode Date: Sun, 12 Dec 2021 08:58:08 +0000 Message-ID: References: <838rwttsxj.fsf@gnu.org> <838rwss37v.fsf@gnu.org> <83tuffr2qd.fsf@gnu.org> <83zgp7p2x1.fsf@gnu.org> <83v8zvovcw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19284"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 52298@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 10:01:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwKjK-0004ok-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 10:01:14 +0100 Original-Received: from localhost ([::1]:57364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwKjI-0002Kj-QK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 04:01:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwKhK-0000sV-LK for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 03:59:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwKhC-0003bV-Pf for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 03:59:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwKhC-0005L3-PB for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 03:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52298 X-GNU-PR-Package: emacs Original-Received: via spool by 52298-submit@debbugs.gnu.org id=B52298.163929950020424 (code B ref 52298); Sun, 12 Dec 2021 08:59:02 +0000 Original-Received: (at 52298) by debbugs.gnu.org; 12 Dec 2021 08:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:50639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwKgW-0005JM-8L for submit@debbugs.gnu.org; Sun, 12 Dec 2021 03:58:20 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:41920 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1mwKgT-0005J6-Ng for 52298@debbugs.gnu.org; Sun, 12 Dec 2021 03:58:18 -0500 Original-Received: (qmail 53466 invoked by uid 3782); 12 Dec 2021 08:58:11 -0000 Original-Received: from acm.muc.de (p2e5d5b9a.dip0.t-ipconnect.de [46.93.91.154]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 12 Dec 2021 09:58:10 +0100 Original-Received: (qmail 4833 invoked by uid 1000); 12 Dec 2021 08:58:08 -0000 Content-Disposition: inline In-Reply-To: <83v8zvovcw.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222192 Archived-At: Hello, Eli. On Sat, Dec 11, 2021 at 20:21:51 +0200, Eli Zaretskii wrote: > > Date: Sat, 11 Dec 2021 17:04:28 +0000 > > Cc: 52298@debbugs.gnu.org > > From: Alan Mackenzie > > So, I suggest I write a commit message and commit that patch. > Which patch? I'm afraid I'm missing something here. This one, the one that should prevent excessive incursions into the redisplay engine when a text property gets set whilst inhibit-modification-hooks is set: diff --git a/src/textprop.c b/src/textprop.c index d7d6a66923..d91b8624ef 100644 --- a/src/textprop.c +++ b/src/textprop.c @@ -85,10 +85,13 @@ modify_text_properties (Lisp_Object buffer, Lisp_Object start, Lisp_Object end) prepare_to_modify_buffer_1 (b, e, NULL); - BUF_COMPUTE_UNCHANGED (buf, b - 1, e); - if (MODIFF <= SAVE_MODIFF) - record_first_change (); - modiff_incr (&MODIFF); + if (!inhibit_modification_hooks) + { + BUF_COMPUTE_UNCHANGED (buf, b - 1, e); + if (MODIFF <= SAVE_MODIFF) + record_first_change (); + modiff_incr (&MODIFF); + } bset_point_before_scroll (current_buffer, Qnil); -- Alan Mackenzie (Nuremberg, Germany).