What's the point of byte-compile-define-keymap?

What's the point of byte-compile-define-keymap?

[Alan Mackenzie]

Hello, Emacs.

It looks to me that byte-compile-define-keymap (in
lisp/emacs-lisp/bytecomp.el) saves its FORM argument in ORIG-FORM and
always returns it unchanged.  This looks like an oversight.

Also, would this function not better be named
byte-compile-FILE-FORM-define-keymap, since it is the value of a
byte-hunk-handler symbol property.

Also[2], is this function really necessary?  Is define-keymap used
sufficiently often to justify a special byte-hunk-handler for it?

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: What's the point of byte-compile-define-keymap?

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> It looks to me that byte-compile-define-keymap (in
> lisp/emacs-lisp/bytecomp.el) saves its FORM argument in ORIG-FORM and
> always returns it unchanged.  This looks like an oversight.

It was rewritten from a byte-optimize function (but it doesn't optimise
anything any more), so it should probably be cleaned up a bit more.

> Also, would this function not better be named
> byte-compile-FILE-FORM-define-keymap, since it is the value of a
> byte-hunk-handler symbol property.
>
> Also[2], is this function really necessary?  Is define-keymap used
> sufficiently often to justify a special byte-hunk-handler for it?

It just used to issue warnings for invalid keymap syntaxes at compile
time.  And, yes, it will be used everywhere.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: What's the point of byte-compile-define-keymap?

[Stefan Monnier]

> It just used to issue warnings for invalid keymap syntaxes at compile
> time.  And, yes, it will be used everywhere.

BTW, you can use a `compiler-macro` for that instead of modifying the
byte-compiler.


        Stefan

Re: What's the point of byte-compile-define-keymap?

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> BTW, you can use a `compiler-macro` for that instead of modifying the
> byte-compiler.

Somebody just volunteered to rewrite these using compiler macros
off-list.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: What's the point of byte-compile-define-keymap?

[Mattias Engdegård]

28 nov. 2021 kl. 14.43 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

> you can use a `compiler-macro` for that instead of modifying the
> byte-compiler.

Done, fixing a compiler-macro annoyance while at it.
People who get build errors may need to bootstrap.