From: Alan Third <alan@idiocy.org>
To: Po Lu <luangruo@yahoo.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: NS port cleanups
Date: Sat, 23 Oct 2021 09:58:53 +0100 [thread overview]
Message-ID: <YXPOzWzugYp/N3wQ@idiocy.org> (raw)
In-Reply-To: <87ee8f8c3z.fsf@yahoo.com>
On Thu, Oct 21, 2021 at 08:17:52AM +0800, Po Lu wrote:
> Alan Third <alan@idiocy.org> writes:
>
> > Looks better, thanks!
>
> > I think I would prefer if you split this along the lines you outlined
> > in the previous email. It's quite a large patch at the moment doing a
> > number of apparently unrelated things.
>
> Will do, thanks. But it would be easier for me if you could review the
> big patch first, and if it's all fine, I'll split it up.
Well, I haven't gone over the changes in nsfont.m in detail because I
don't really understand what any of that code does, but aside from
that and the issues I've already raised I don't see anything of concern.
> > Can I ask why you're saving the context every time ns_focus is called?
> > It shouldn't be necessary unless we're making a change, like calling
> > NSRectClip. Any deeper functions that make changes save and restore
> > the context locally.
>
> That makes it easier to nest ns_focus. (Unless that's a bad idea, I
> think it should work.)
Is there any reason to nest ns_focus? There are (according to Apple)
performance reasons to not save the context unless you really need to.
> >> @@ -9867,7 +9873,11 @@ Convert an X font name (XLFD) to an NS font name.
> >> \n\
> >> Each SYMBOL is `control', `meta', `alt', `super', `hyper' or `none'.\n\
> >> If `none', the key is ignored by Emacs and retains its standard meaning.");
> >> +#ifdef NS_IMPL_GNUSTEP
> >> + ns_alternate_modifier = Qalt;
> >> +#else
> >> ns_alternate_modifier = Qmeta;
> >> +#endif
> >>
> >> DEFVAR_LISP ("ns-right-alternate-modifier", ns_right_alternate_modifier,
> >> "This variable describes the behavior of the right alternate or option key.\n\
> >> @@ -9888,7 +9898,11 @@ Convert an X font name (XLFD) to an NS font name.
> >> \n\
> >> Each SYMBOL is `control', `meta', `alt', `super', `hyper' or `none'.\n\
> >> If `none', the key is ignored by Emacs and retains its standard meaning.");
> >> +#ifdef NS_IMPL_GNUSTEP
> >> + ns_command_modifier = Qmeta;
> >> +#else
> >> ns_command_modifier = Qsuper;
> >> +#endif
>
> > We have command bound to super so the default Openstep shortcuts work,
> > like cmd-q to quit, and alt bound to meta, because that's pretty
> ^^^
> > standard in Emacs.
>
> What do you mean by "alt" here? If it means the "alt" key on the user's
> keyboard, then I think setting ns_command_modifier to meta is TRT,
> because on most systems that will be the left alt key.
I mean alt as defined by GNUstep in the quote I sent you in my last
email. I don't think it's our job to say that GNUstep's choice of
defaults is wrong and therefore do something that would be unexpected
for a GNUstep user.
--
Alan Third
next prev parent reply other threads:[~2021-10-23 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87czo3bxog.fsf.ref@yahoo.com>
2021-10-17 13:14 ` bug#51251: 29.0.50; Moving cursor on top of raised box leaves artifacts around in NS port Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-17 18:37 ` Alan Third
2021-10-18 0:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-19 20:27 ` Alan Third
2021-10-17 19:00 ` Alan Third
2021-10-19 9:40 ` NS port cleanups Po Lu
2021-10-19 20:22 ` Alan Third
2021-10-20 0:40 ` Po Lu
2021-10-20 5:01 ` Po Lu
2021-10-20 12:44 ` Po Lu
2021-10-20 20:12 ` Alan Third
2021-10-21 0:17 ` Po Lu
2021-10-23 8:58 ` Alan Third [this message]
2021-10-23 11:19 ` Po Lu
2021-10-23 9:09 ` Alan Third
2021-10-23 11:20 ` Po Lu
2021-10-23 12:00 ` Po Lu
2021-10-23 19:31 ` Carlos Pita
2021-10-25 11:33 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXPOzWzugYp/N3wQ@idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.