From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Inadequate coding in hack-elisp-shorthands Date: Fri, 1 Oct 2021 17:03:44 +0000 Message-ID: References: <83czopfg2x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 01 19:05:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWLy4-0001rq-Ni for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 19:05:04 +0200 Original-Received: from localhost ([::1]:38290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWLy3-0005UA-Gy for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 13:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWLwv-0004hX-1t for emacs-devel@gnu.org; Fri, 01 Oct 2021 13:03:53 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:11521 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mWLws-0006Dg-0i for emacs-devel@gnu.org; Fri, 01 Oct 2021 13:03:52 -0400 Original-Received: (qmail 24048 invoked by uid 3782); 1 Oct 2021 17:03:45 -0000 Original-Received: from acm.muc.de (p4fe15cf0.dip0.t-ipconnect.de [79.225.92.240]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 Oct 2021 19:03:45 +0200 Original-Received: (qmail 7505 invoked by uid 1000); 1 Oct 2021 17:03:44 -0000 Content-Disposition: inline In-Reply-To: <83czopfg2x.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275997 Archived-At: Hello, Eli. On Fri, Oct 01, 2021 at 08:51:18 +0300, Eli Zaretskii wrote: > > Date: Thu, 30 Sep 2021 20:35:17 +0000 > > From: Alan Mackenzie > > In emacs -Q in the emacs-28 branch, create the following two line file, > > foobar.el, and try to load it: > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > (defvar foo-baz "foobar-baz") > > FOOBARELISP-SHORTHANDS: (("foo" . "foobar"))) > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > This will throw an error, but that isn't important. > > What is important is that the symbol foobar-baz is created by the > > elisp-shorthands facility. > > This shouldn't happen since: > > 1/- There is no Local Variables section. > > 2/- There is no variable elisp-shorthands in that non-existent section. > > The following errors are evident in hack-elisp-shorthands: > > 1/- The code doesn't check for a correctly formatted Local Variables > > section. > > 2/- The code, even if it did check, would only check the last 3000 bytes > > in the file. The section can occur anywhere in the last 3000 > > CHARACTERS. > > 3/- The code doesn't do a case-sensitive search for "elisp-shorthands". > > 4/- The code doesn't check for "elisp-shorthands" being a complete > > symbol. > > 5/- The code doesn't even check that "elisp-shorthands" is in a comment. > > I would suggest that these errors be corrected. I would also suggest > > that the entire code and documentation for this new facility be > > carefully reviewed by somebody who isn't the original author. > Thanks, but why isn't this a full-blown bug report, submitted to > debbugs? The last sentence - I was hoping to recruit somebody (somebody more enthusiastic about the feature than me) to do the reviewing, and this is more likely on emacs-devel than debbugs. But I'll resubmit it as a bug this evening. -- Alan Mackenzie (Nuremberg, Germany).