From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Inadequate coding in hack-elisp-shorthands Date: Thu, 30 Sep 2021 20:35:17 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17598"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 30 22:37:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mW2o0-0004HU-Az for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 22:37:24 +0200 Original-Received: from localhost ([::1]:35244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW2nx-0008Bk-J5 for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Sep 2021 16:37:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW2m1-0006LS-Ra for emacs-devel@gnu.org; Thu, 30 Sep 2021 16:35:21 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:36481 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mW2lz-0006HG-Nx for emacs-devel@gnu.org; Thu, 30 Sep 2021 16:35:21 -0400 Original-Received: (qmail 34236 invoked by uid 3782); 30 Sep 2021 20:35:17 -0000 Original-Received: from acm.muc.de (p4fe15a46.dip0.t-ipconnect.de [79.225.90.70]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 30 Sep 2021 22:35:17 +0200 Original-Received: (qmail 8097 invoked by uid 1000); 30 Sep 2021 20:35:17 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_05=-0.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275928 Archived-At: Hello, Emacs. In emacs -Q in the emacs-28 branch, create the following two line file, foobar.el, and try to load it: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defvar foo-baz "foobar-baz") FOOBARELISP-SHORTHANDS: (("foo" . "foobar"))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; This will throw an error, but that isn't important. What is important is that the symbol foobar-baz is created by the elisp-shorthands facility. This shouldn't happen since: 1/- There is no Local Variables section. 2/- There is no variable elisp-shorthands in that non-existent section. The following errors are evident in hack-elisp-shorthands: 1/- The code doesn't check for a correctly formatted Local Variables section. 2/- The code, even if it did check, would only check the last 3000 bytes in the file. The section can occur anywhere in the last 3000 CHARACTERS. 3/- The code doesn't do a case-sensitive search for "elisp-shorthands". 4/- The code doesn't check for "elisp-shorthands" being a complete symbol. 5/- The code doesn't even check that "elisp-shorthands" is in a comment. I would suggest that these errors be corrected. I would also suggest that the entire code and documentation for this new facility be carefully reviewed by somebody who isn't the original author. -- Alan Mackenzie (Nuremberg, Germany).