From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: master b72f885: Make dlet work like let, not let* Date: Mon, 20 Sep 2021 20:02:15 +0300 Message-ID: References: <83wnp5m9i5.fsf@gnu.org> <9DE2F5D1-A89A-4357-9E46-268F697D8260@acm.org> <837dh2mz57.fsf@gnu.org> <74C5058D-AF5C-4F1A-8D08-251935A69693@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21423"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) Cc: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 19:13:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSMr5-0005Rp-MD for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 19:13:23 +0200 Original-Received: from localhost ([::1]:36596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSMr3-0000Py-91 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 13:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSMk1-0006iL-46 for emacs-devel@gnu.org; Mon, 20 Sep 2021 13:06:05 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:39495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSMjz-0004tX-2S; Mon, 20 Sep 2021 13:06:04 -0400 Original-Received: from localhost ([::ffff:41.210.154.92]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 0000000000075FAB.000000006148BF76.00005C56; Mon, 20 Sep 2021 10:05:58 -0700 Mail-Followup-To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <74C5058D-AF5C-4F1A-8D08-251935A69693@acm.org> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275157 Archived-At: * Mattias Engdegård [2021-08-03 18:22]: > The change itself is also low-risk: it's an esoteric function and > I've found no use of it anywhere outside the Emacs tree -- I did > search. Furthermore, even inside Emacs all uses were found to be > insensitive to the let/let* binding semantics. If you don't use it, I do and it is one important function to my work, I use it few times in few files related to variables interpolation in templates and dynamic code fetching and re-use. And I have not ever considered it `esoteric'. grep --color=auto -nH -e dlet *.el rcd-cf.el:6870: (dlet ((wrs-text text)) rcd-cf.el:6889: (dlet ((wrs::page (rcd-db-table-id-hash "pages" page-id cf-db)) rcd-cf.el:6919: (dlet ((wrs::text (rcd-template-eval (gethash "pages_content" wrs::page "") '("⟦" "⟧") wrs::variables)) rcd-cf.el:6922: (dlet ((wrs::template (gethash "templates_content" wrs::template)) rcd-utilities.el:1480: (dlet ((wrs-processor "asciidoctor")) > Well sort of: if someones finds out about a construct named `dlet`, > it's just natural to assume that it binds like `let`, not like > `let*`. (Supporting evidence: two local macros on the pattern > `something-dlet*` were in use. One of the has now been renamed.) For me it is not natural. `dlet' is supposed to bind variables dynamically and with this change it doesn't. Basically the function is ruined how I see it. Your proposal is not logical and that you just changed it without deeper analysis is very suprising. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/