Re: master b72f885: Make dlet work like let, not let*

[Jean Louis <bugs@gnu.support>]

* Mattias Engdegård <mattiase@acm.org> [2021-08-03 18:22]:
> The change itself is also low-risk: it's an esoteric function and
> I've found no use of it anywhere outside the Emacs tree -- I did
> search. Furthermore, even inside Emacs all uses were found to be
> insensitive to the let/let* binding semantics.

If you don't use it, I do and it is one important function to my work,
I use it few times in few files related to variables interpolation in
templates and dynamic code fetching and re-use. And I have not ever
considered it `esoteric'.

grep --color=auto -nH -e dlet *.el
rcd-cf.el:6870:  (dlet ((wrs-text text))
rcd-cf.el:6889:  (dlet ((wrs::page (rcd-db-table-id-hash "pages" page-id cf-db))
rcd-cf.el:6919:    (dlet ((wrs::text (rcd-template-eval (gethash "pages_content" wrs::page "") '("⟦" "⟧") wrs::variables))
rcd-cf.el:6922:      (dlet ((wrs::template (gethash "templates_content" wrs::template))
rcd-utilities.el:1480:  (dlet ((wrs-processor "asciidoctor"))

> Well sort of: if someones finds out about a construct named `dlet`,
> it's just natural to assume that it binds like `let`, not like
> `let*`. (Supporting evidence: two local macros on the pattern
> `something-dlet*` were in use. One of the has now been renamed.)

For me it is not natural. `dlet' is supposed to bind variables
dynamically and with this change it doesn't. Basically the function is
ruined how I see it.

Your proposal is not logical and that you just changed it without
deeper analysis is very suprising.


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/