all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing post-self-insert-hook.
Date: Sat, 18 Sep 2021 09:41:10 +0000	[thread overview]
Message-ID: <YUW0NtlCWuMdbyGw@ACM> (raw)
In-Reply-To: <83fsu277ad.fsf@gnu.org>

Hello, Eli.

On Sat, Sep 18, 2021 at 08:59:54 +0300, Eli Zaretskii wrote:
> > Date: Fri, 17 Sep 2021 20:35:50 +0000
> > From: Alan Mackenzie <acm@muc.de>
> > Cc: emacs-devel@gnu.org

> > The point is, these calls are currently undefined.  Pretty much every
> > last one of them, apart from the ones in cc-cmds.el, which have been
> > made defined again.

> > These 111 calls might have been working, they might not, they might have
> > sort of been working as long as electric-pair-mode isn't enabled.  Who
> > knows?  They're currently in a sort of race condition.

> If they aren't working, where are the bug reports about that?

They don't work, at least some of them.  That is evident from examining
the source code and mechanisms involved.  As for bug reports, there are
many thousand open ones which Lars is heroically working through, some
of which don't have obvious causes.

> We only have bug reports about CC mode so far.

The bugs are, however, not in CC Mode and can't be fixed there.  They
can only be worked around, which is what has been done since bug #33794
at the end of 2018.  This workaround is ugly and caused bad feeling at
the time.

> > So, yes, you're basically right.  We should move the call to p-s-i-h not
> > just to fix the interface to electric-pair-mode and friends, but to
> > bring sanity back to Emacs with respect to this matter.

> I'm against such changes, as you well know.

Indeed!  I can only respect that whilst disagreeing strongly with it.
I've never been a fan of "it mostly works, so don't touch it!".

> With Emacs, "sane" is mostly defined as the status quo, because Emacs
> "mostly works".  Any significant change in such a low-level facility
> is, therefore, "insane", IMNSHO, unless the problem is also general.

The problem is indeed general, in the sense that self-insert-function is
general.  The effects of the problem have only been felt in the
electric-... minor modes so far.

> And we don't have evidence that the problem is global.

We have a complete understanding of how self-insert-function is broken.
This has had damaging effects in the interface between
electric-pair-mode and CC Mode for which workarounds were installed in
CC Mode.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2021-09-18  9:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 19:37 Fixing post-self-insert-hook Alan Mackenzie
2021-09-17 20:04 ` Stefan Monnier
2021-09-17 20:53   ` Alan Mackenzie
2021-09-17 21:45     ` João Távora
2021-09-18  6:08       ` tomas
2021-09-18  8:44         ` João Távora
2021-09-18 14:15     ` Stefan Monnier
2021-09-18 15:56       ` Alan Mackenzie
2021-09-18 18:03         ` Stefan Monnier
     [not found]         ` <CALDnm52z_8HyqdC92nrMgzOMOOq48h2MQ4pjbROBOsdm5N_cJg@mail.gmail.com>
2021-09-18 22:55           ` João Távora
2021-09-19 12:14             ` Alan Mackenzie
2021-09-19 12:36               ` João Távora
2021-09-19 12:59               ` Stefan Monnier
2021-09-19 14:57                 ` Alan Mackenzie
2021-09-19 20:20                   ` Stefan Monnier
2021-09-17 20:15 ` João Távora
2021-09-17 20:35   ` Alan Mackenzie
2021-09-17 20:48     ` João Távora
2021-09-18  5:59     ` Eli Zaretskii
2021-09-18  9:41       ` Alan Mackenzie [this message]
2021-09-18  5:50 ` Eli Zaretskii
2021-09-18  9:57   ` Alan Mackenzie
2021-09-18 11:04     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUW0NtlCWuMdbyGw@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.