* bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation
@ 2021-08-29 16:44 Clément Pit-Claudel
2021-08-29 17:46 ` Alan Third
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Clément Pit-Claudel @ 2021-08-29 16:44 UTC (permalink / raw)
To: 50255; +Cc: Andrea Corallo
[-- Attachment #1.1.1: Type: text/plain, Size: 400 bytes --]
Hi Andrea, hi all,
There seems to be a few places where the rename from with-nativecomp to with-native-compilation was missed; I've attached a patch.
All of them were in messages, which explains why they weren't caught; but one of them is in an EMBA file, which is more surprising, since I would have expected it to cause issues (?) Are these tests actually working right now?
Clément.
[-- Attachment #1.1.2: 0001-Change-with-nativecomp-to-with-native-compilation-in.patch --]
[-- Type: text/x-patch, Size: 3578 bytes --]
From 5674820b6c1e6ab2005904d0e7a6574270bc6837 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= <clement.pitclaudel@live.com>
Date: Sun, 29 Aug 2021 12:33:36 -0400
Subject: [PATCH] Change --with-nativecomp to --with-native-compilation in
messages
The flag was renamed in 42fc752a14.
* configure.ac:
* test/infra/Dockerfile.emba:
* test/infra/gitlab-ci.yml: Fix mentions of --with-nativecomp
---
configure.ac | 6 +++---
test/infra/Dockerfile.emba | 2 +-
test/infra/gitlab-ci.yml | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 76f608ffb0..a1deb7b0dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3795,7 +3795,7 @@ AC_DEFUN
not found.
Please try installing libgccjit-dev or a similar package.
If you are sure you want Emacs be compiled without ELisp native compiler,
-pass the --without-nativecomp option to configure.])])
+pass the --without-native-compilation option to configure.])])
AC_DEFUN([libgccjit_broken], [
AC_MSG_ERROR([The installed libgccjit failed to compile and run a test program using
@@ -3814,10 +3814,10 @@ AC_DEFUN
LIBGCCJIT_CFLAGS=
if test "${with_native_compilation}" != "no"; then
if test "${HAVE_PDUMPER}" = no; then
- AC_MSG_ERROR(['--with-nativecomp' requires '--with-dumping=pdumper'])
+ AC_MSG_ERROR(['--with-native-compilation' requires '--with-dumping=pdumper'])
fi
if test "${HAVE_ZLIB}" = no; then
- AC_MSG_ERROR(['--with-nativecomp' requires zlib])
+ AC_MSG_ERROR(['--with-native-compilation' requires zlib])
fi
# Ensure libgccjit installed by Homebrew can be found.
diff --git a/test/infra/Dockerfile.emba b/test/infra/Dockerfile.emba
index 9f03482c3f..0b61c74aef 100644
--- a/test/infra/Dockerfile.emba
+++ b/test/infra/Dockerfile.emba
@@ -82,6 +82,6 @@ ARG make_bootstrap_params=""
COPY . /checkout
WORKDIR /checkout
RUN ./autogen.sh autoconf
-RUN ./configure --with-nativecomp
+RUN ./configure --with-native-compilation
RUN make bootstrap -j2 NATIVE_FULL_AOT=1 BYTE_COMPILE_EXTRA_FLAGS='--eval "(setq comp-speed 0)"'
RUN make -j4
diff --git a/test/infra/gitlab-ci.yml b/test/infra/gitlab-ci.yml
index 6876a8b11d..5082b08e01 100644
--- a/test/infra/gitlab-ci.yml
+++ b/test/infra/gitlab-ci.yml
@@ -291,7 +291,7 @@ build-native-bootstrap-speed0:
# script:
# - DEBIAN_FRONTEND=noninteractive apt install --no-install-recommends -y -qq -o=Dpkg::Use-Pty=0 libgccjit-6-dev
# - ./autogen.sh autoconf
-# - ./configure --with-nativecomp
+# - ./configure --with-native-compilation
# - make bootstrap NATIVE_FULL_AOT=1 BYTE_COMPILE_EXTRA_FLAGS='--eval "(setq comp-speed 0)"' -j2
# timeout: 8 hours
@@ -300,7 +300,7 @@ build-native-bootstrap-speed0:
# script:
# - DEBIAN_FRONTEND=noninteractive apt install --no-install-recommends -y -qq -o=Dpkg::Use-Pty=0 libgccjit-6-dev
# - ./autogen.sh autoconf
-# - ./configure --with-nativecomp
+# - ./configure --with-native-compilation
# - make bootstrap BYTE_COMPILE_EXTRA_FLAGS='--eval "(setq comp-speed 1)"'
# timeout: 8 hours
@@ -309,7 +309,7 @@ build-native-bootstrap-speed0:
# script:
# - DEBIAN_FRONTEND=noninteractive apt install --no-install-recommends -y -qq -o=Dpkg::Use-Pty=0 libgccjit-6-dev
# - ./autogen.sh autoconf
-# - ./configure --with-nativecomp
+# - ./configure --with-native-compilation
# - make bootstrap
# timeout: 8 hours
--
2.25.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation
2021-08-29 16:44 bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation Clément Pit-Claudel
@ 2021-08-29 17:46 ` Alan Third
2021-08-29 19:15 ` Lars Ingebrigtsen
2021-08-30 9:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2 siblings, 0 replies; 4+ messages in thread
From: Alan Third @ 2021-08-29 17:46 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 50255, Andrea Corallo
On Sun, Aug 29, 2021 at 12:44:05PM -0400, Clément Pit-Claudel wrote:
>
> All of them were in messages, which explains why they weren't
> caught; but one of them is in an EMBA file, which is more
> surprising, since I would have expected it to cause issues (?) Are
> these tests actually working right now?
Emba's builds have been broken for quite a while.
https://lists.nongnu.org/archive/html/emacs-build-automation/2021-06/msg00001.html
--
Alan Third
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation
2021-08-29 16:44 bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation Clément Pit-Claudel
2021-08-29 17:46 ` Alan Third
@ 2021-08-29 19:15 ` Lars Ingebrigtsen
2021-08-30 9:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-29 19:15 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 50255, Andrea Corallo
Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
> There seems to be a few places where the rename from with-nativecomp
> to with-native-compilation was missed; I've attached a patch.
Thanks; applied to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation
2021-08-29 16:44 bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation Clément Pit-Claudel
2021-08-29 17:46 ` Alan Third
2021-08-29 19:15 ` Lars Ingebrigtsen
@ 2021-08-30 9:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2 siblings, 0 replies; 4+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-08-30 9:39 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 50255
Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
> Hi Andrea, hi all,
>
> There seems to be a few places where the rename from with-nativecomp to with-native-compilation was missed; I've attached a patch.
Hi Clément, thanks for the patch form me as well.
Andrea
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-30 9:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-29 16:44 bug#50255: [PATCH] Finish renaming with-nativecomp to with-native-compilation Clément Pit-Claudel
2021-08-29 17:46 ` Alan Third
2021-08-29 19:15 ` Lars Ingebrigtsen
2021-08-30 9:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.