all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: What's the best (i.e. least bad) way to re-redisplay?
Date: Thu, 26 Aug 2021 17:02:16 +0000	[thread overview]
Message-ID: <YSfJGBycpIa1pNhs@ACM> (raw)
In-Reply-To: <jwv4kbcz5ud.fsf-monnier+emacs@gnu.org>

Hello, Stefan.

On Thu, Aug 26, 2021 at 09:49:33 -0400, Stefan Monnier wrote:
> >> > I think something along the lines of

> >> >     (run-with-timer 0 nil
> >> >                     (lambda (buf)
> >> >                       (with-current-buffer buf (font-lock-flush)))
> >> >                     (current-buffer))

> >> > is the cleanest that comes to mind.

> >> Thanks.  That's probably cleaner than a direct use of
> >> jit-lock-force-redisplay.

> > Why is it cleaner?  jit-lock and font-lock include provision for the
> > fontification function to tell jit-lock what was the region actually
> > fontified, and that will trigger a call to jit-lock-force-redisplay in
> > a timer.  Why not use an existing mechanism?

> That's indeed another option.  I assumed that the situation is such that
> while fontifying region POS1..POS2 we discover a new type that forces
> the whole buffer to be refontified (or at least some region POS3..POS4),
> in which case it's best to use `font-lock-flush` and let this
> refontification happen lazily.

My idea is that, say, a new type "foo" is found by stealth fontification.
CC Mode will then do a regexp search for "\\_<foo\\_>" from BOB to EOB
removing 'fontified text properties from each match it finds.  This is
fast (around 10ms per found type in xdisp.c).  It should be enough to
force (re)fontification of (the statements containing) "foo" whenever
these occurrences are scrolled onto.  Then there's the currently
displayed window, as we've been discussing.

That, of course, involves somehow persuading the user to enable stealth
fontification.

> But if indeed we can cheaply adjust the few places in the buffer that
> are affected without performing a full "refontify" it might indeed be
> a good idea to do that and adjust the `jit-lock-bounds` return value,
> but in that case we have to be sure that the new bounds indeed describe
> an area of the buffer that is now fully fontified, which is likely to be
> a problem because there is no reason to assume that the buffer outside
> of POS1..POS2 had already been fontified, so it may force us to eagerly
> fontify additional parts of POS3..POS4.

> Another option if we can cheaply adjust the few places in the buffer that
> are affected without performing a full "refontify", is to do those
> adjustments and then only force a redisplay but not a refontification.

This is exactly my plan.

> I think this can be done with something like:

>     (run-with-timer 0 nil
>                     (lambda (buf)
>                       (with-current-buffer buf
>                         (put-text-property (point-min) (point-max) 'cc-dummy t)
>                         (remove-text-properties (point-min) (point-max) '(cc-dummy))))
>                     (current-buffer))

I don't understand what that bit of code's doing.

> -- Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2021-08-26 17:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 18:41 What's the best (i.e. least bad) way to re-redisplay? Alan Mackenzie
2021-08-23 19:35 ` Eli Zaretskii
2021-08-23 19:57   ` Eli Zaretskii
2021-08-24 10:56   ` Alan Mackenzie
2021-08-24 22:43 ` Stefan Monnier
2021-08-25 20:09   ` Alan Mackenzie
2021-08-25 20:36     ` Stefan Monnier
2021-08-26  6:37     ` Eli Zaretskii
2021-08-26 13:49       ` Stefan Monnier
2021-08-26 17:02         ` Alan Mackenzie [this message]
2021-08-26 19:27           ` Stefan Monnier
2021-08-30 18:10       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSfJGBycpIa1pNhs@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.