all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: What's the best (i.e. least bad) way to re-redisplay?
Date: Tue, 24 Aug 2021 10:56:07 +0000	[thread overview]
Message-ID: <YSTQR0tEtGMLWmgy@ACM> (raw)
In-Reply-To: <83fsv0vts5.fsf@gnu.org>

Hello, Eli.

On Mon, Aug 23, 2021 at 22:35:22 +0300, Eli Zaretskii wrote:
> > Date: Mon, 23 Aug 2021 18:41:59 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > I envisage a situation where an identifier is identified as a type during
> > jit-lock fontification, and thus font-lock-type-face needs to be applied
> > to all occurrences of this identifier.

> > The problem is, there will be occurences in the foreground window before
> > the one which triggered the fontification.  Redisplay will already have
> > passed this earlier buffer position.  So I need to trigger another
> > redisplay immediately after the current one.

> > What is the least bad way of doing this?

> You mean, the same identifier is somewhere in the same window-ful, but
> before the position where you suddenly decided your previous
> fontification was incorrect?  (Why is this a reasonable scenario,
> btw?)

For example, in a C file we have a function prototype without parameter
names:

     fooMain (foo);

, and later on this gets fleshed out:

     fooMain (foo bar)
     {
     ....
     }

The first occurrence will get fontified as a function call, I think.
Only when we pass the second occurrence do we see foo must be a type.

> > Currently, I'm thinking of something like the CC Mode fontification
> > functions setting a flag, and a repeating timer function testing this
> > flag every 0.025s, say, and triggering a redisplay if it's set.

> Why not simply call a one-time timer function that runs
> jit-lock-force-redisplay, when you decide that you need to refontify?
> jit-lock.el already does that in some cases.  I see no reason to have
> a periodic timer and a flag, because the same code that sets the flag
> could instead arm a one-time timer.

Thanks, that's exactly the answer I was asking for.  :-)  I didn't know
about jit-lock-force-display.

> > One problem is knowing whether or not redisplay is currently active.  Is
> > there a simple way to do this in Lisp?  (I know there is in C.)

> I don't understand your problem here.  Timers cannot run while
> redisplay works, because timers are only run by the main loop.  So
> when a timer runs, redisplay by definition isn't.

That was going off on a bit of a tangent.  If the above situation occurs
when we know we're not already in redisplay, we could simply call
redisplay without using a timer.  I suppose it's not really that important.

-- 
Alan Mackenzie (Nuremberg, Germany).



  parent reply	other threads:[~2021-08-24 10:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 18:41 What's the best (i.e. least bad) way to re-redisplay? Alan Mackenzie
2021-08-23 19:35 ` Eli Zaretskii
2021-08-23 19:57   ` Eli Zaretskii
2021-08-24 10:56   ` Alan Mackenzie [this message]
2021-08-24 22:43 ` Stefan Monnier
2021-08-25 20:09   ` Alan Mackenzie
2021-08-25 20:36     ` Stefan Monnier
2021-08-26  6:37     ` Eli Zaretskii
2021-08-26 13:49       ` Stefan Monnier
2021-08-26 17:02         ` Alan Mackenzie
2021-08-26 19:27           ` Stefan Monnier
2021-08-30 18:10       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSTQR0tEtGMLWmgy@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.