From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language Date: Fri, 20 Aug 2021 21:20:49 +0000 Message-ID: References: <874kbrr4cq.fsf@gnus.org> <87sfz9fx0y.fsf@gnus.org> <87bl5vhng9.fsf@tcd.ie> <87sfz7fwlv.fsf@tcd.ie> <87k0kiguif.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , emacs-devel@gnu.org To: "Basil L. Contovounesios" , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 20 23:22:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHByQ-00098U-VC for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Aug 2021 23:22:46 +0200 Original-Received: from localhost ([::1]:39570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHByP-0000yo-5G for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Aug 2021 17:22:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHBwc-0008Oe-Tp for emacs-devel@gnu.org; Fri, 20 Aug 2021 17:20:54 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:50283 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mHBwa-00087i-Mx for emacs-devel@gnu.org; Fri, 20 Aug 2021 17:20:54 -0400 Original-Received: (qmail 51439 invoked by uid 3782); 20 Aug 2021 21:20:50 -0000 Original-Received: from acm.muc.de (p4fe156d5.dip0.t-ipconnect.de [79.225.86.213]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 20 Aug 2021 23:20:49 +0200 Original-Received: (qmail 31052 invoked by uid 1000); 20 Aug 2021 21:20:49 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272745 Archived-At: Hello, Lars and Basil. On Fri, Aug 20, 2021 at 10:48:04 +0000, Alan Mackenzie wrote: [ .... ] > The problem is a bug in c-point-syntax. There, there is > (i) an invocation of c-save-buffer-state, which binds buffer-undo-list > to t, followed by > (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto > buffer-undo-list (simulating an undo group) giving (nil t). > (iii) A { is typed into the buffer, giving buffer-undo-list now as > something like ((5128 . 5129) nil t). > At this point garbage collection occurs. This strips the tail of > buffer-undo-list, leaving ((5128 . 5129)). > (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely, > since buffer-undo-list will never become the expected value (nil t). > The problem would appear to be the invalid value ((5128 . 5129) nil t) in > buffer-undo-list. > I'll see what I can do about this tonight. I've just committed a patch to master which I think fixes the problem. Thanks especially to Basil for exceptionally helpful debugging info. > > -- > > Basil -- Alan Mackenzie (Nuremberg, Germany).