all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Jim Myhrberg <contact@jimeh.me>
Cc: 49270@debbugs.gnu.org
Subject: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files
Date: Tue, 29 Jun 2021 22:06:43 +0100	[thread overview]
Message-ID: <YNuLYwh6EjC3ebE2@breton.holly.idiocy.org> (raw)
In-Reply-To: <CAGaZ61uhwwrdiW94_c0DJvkUrR_1QJ7WHEXSqB25bw10O9rEog@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

On Tue, Jun 29, 2021 at 12:51:48PM +0100, Jim Myhrberg wrote:
> When performing a self-contained Emacs.app build, *.eln files for
> Emacs' built-in lisp files stored within the Emacs.app bundle are not
> used.
> 
> I believe commit 5dd2d50 which moved *.eln files and various paths
> around a bit for macOS builds, has re-introduced an old bug from last
> year. Basically the checksums that makes up part of the *.eln file
> names uses the absolute path of the .el file in question, but for self
> contained .app builds it needs to just use the relative path to the
> app itself.

I don't think this is the same bug (although I guess it has the same
symptoms).

Please try the attached patch, it fixes it here.
-- 
Alan Third

[-- Attachment #2: 0001-Fix-NS-native-comp-search-path-bug-49270.patch --]
[-- Type: text/plain, Size: 850 bytes --]

From 0517874eb4bce2cbbcdf58516c43d50b0174c0ec Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Tue, 29 Jun 2021 22:02:43 +0100
Subject: [PATCH] Fix NS native comp search path (bug#49270)

* configure.ac (NS_SELF_CONTAINED): We need to make lispdirrel the
same as lispdir when building a self contained app bundle as they're
both relative paths.
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index c8920d877e..6e2cda947a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2025,6 +2025,7 @@ AC_DEFUN
      infodir="\${ns_appresdir}/info"
      mandir="\${ns_appresdir}/man"
      lispdir="\${ns_appresdir}/lisp"
+     lispdirrel="\${ns_appresdir}/lisp"
      test "$locallisppathset" = no && locallisppath="\${ns_appresdir}/site-lisp"
      INSTALL_ARCH_INDEP_EXTRA=
   fi
-- 
2.29.2


  parent reply	other threads:[~2021-06-29 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 11:51 bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files Jim Myhrberg
2021-06-29 12:25 ` Eli Zaretskii
2021-06-29 13:07   ` Jim Myhrberg
2021-06-29 18:11 ` Eli Zaretskii
2021-06-29 21:06 ` Alan Third [this message]
2021-06-30  9:32   ` Jim Myhrberg
2021-07-01 21:16     ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNuLYwh6EjC3ebE2@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=49270@debbugs.gnu.org \
    --cc=contact@jimeh.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.