From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window Date: Wed, 23 Jun 2021 17:06:12 +0100 Message-ID: References: <20210620155625.12886.44156@vcs0.savannah.gnu.org> <20210620155629.258B620B76@vcs0.savannah.gnu.org> <87h7hosqob.fsf@gmail.com> <874kdosk69.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1730"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 23 18:07:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw5PM-0000Ft-H0 for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 18:07:20 +0200 Original-Received: from localhost ([::1]:34028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw5PL-0002Gr-Ik for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Jun 2021 12:07:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw5OP-0000v6-7P for emacs-devel@gnu.org; Wed, 23 Jun 2021 12:06:21 -0400 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:65::8:228]:46397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw5OM-0003C5-PD for emacs-devel@gnu.org; Wed, 23 Jun 2021 12:06:20 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 865F2963; Wed, 23 Jun 2021 16:06:15 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1624464375; bh=8iRn0AX8scY2+9jlDC3EcMzjq0vjkx67wnGGEmjUX2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C/lGcFU8iYQPnHpS4AIkSAUp7BSmVQROc5UD/gqnKaO1T+Nc9wHjj6hf83+okMWLk 0QQUADudj9MhQMGB8TkYdym4X5DMJC9NaIen0RSqjUSdwAADvCA93D+vJmQK5pF+mJ alGEbzqNyYqHnnrPbq+lkuzloN7SodnCj4CiOzhqBAmehC2H0YJiVHhuzNxu9hpq2L MP46ELAht4gyLuXb0lpunVjWZGgTx+WHfuzHlR3CpgrDlnMHjOaSmF+UAD+Xws5IqD Q7LJQYh7eXMrFtqBzz/s0UTT3VNaT18ydUFZUrYklzoyDpoHrQ7fjqpRNjMGk0252m piiUa52lRwCcg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lw5OG-0017Z2-9q; Wed, 23 Jun 2021 17:06:12 +0100 Mail-Followup-To: Alan Third , Robert Pluim , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <874kdosk69.fsf@gmail.com> Received-SPF: pass client-ip=2a01:4f8:fff0:65::8:228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270994 Archived-At: On Wed, Jun 23, 2021 at 04:57:34PM +0200, Robert Pluim wrote: > >>>>> On Wed, 23 Jun 2021 15:27:42 +0100, Alan Third said: > >> The second frame has the tool-bar disabled, but unlike master the > >> frame height is greater than the initial frame, and the frame title is > >> bigger as well, as if its height had not been adjusted after removing > >> the tool-bar. > > Alan> What's happening is that the toolbar is set to be visible, but it has > Alan> nothing in it, so it shrinks to the toolbar's minimum height. > > Alan> Can you please try the following, I think it should sort it: > > Youʼre on a roll here Alan. That fixes it. I've pushed a fix if you want to give it a go. Plus another couple of patches which probably break something else. -- Alan Third