Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window

[Alan Third <alan@idiocy.org>]

On Wed, Jun 23, 2021 at 02:37:08PM +0200, Robert Pluim wrote:
> >>>>> On Sun, 20 Jun 2021 11:56:28 -0400 (EDT), alan@idiocy.org (Alan Third) said:
> 
>     Alan> branch: scratch/ns/refactor
>     Alan> commit 06d9e723f79390eb6151f521d154b47e1ffa943e
>     Alan> Author: Alan Third <alan@idiocy.org>
>     Alan> Commit: Alan Third <alan@idiocy.org>
> 
>     Alan>     Move NS port toolbar handling to the window
> 
> Hi Alan, I tried this branch. I did

Thanks for trying it.

> emacs -Q
> (tool-bar-mode -1)
> C-x 5 2
> 
> The second frame has the tool-bar disabled, but unlike master the
> frame height is greater than the initial frame, and the frame title is
> bigger as well, as if its height had not been adjusted after removing
> the tool-bar.

What's happening is that the toolbar is set to be visible, but it has
nothing in it, so it shrinks to the toolbar's minimum height.

Can you please try the following, I think it should sort it:

modified   src/nsmenu.m
@@ -1089,10 +1089,10 @@ - (void)menu:(NSMenu *)menu willHighlightItem:(NSMenuItem *)item
 #undef TOOLPROP
     }
 
-  if (![toolbar isVisible])
+  if ([toolbar isVisible] != FRAME_EXTERNAL_TOOL_BAR (f))
     {
       f->output_data.ns->in_animation = 1;
-      [toolbar setVisible: YES];
+      [toolbar setVisible: FRAME_EXTERNAL_TOOL_BAR (f)];
       f->output_data.ns->in_animation = 0;
     }
 
-- 
Alan Third