From: Jean Louis <bugs@gnu.support>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Example use of macro to minimize and generalize the code
Date: Tue, 1 Jun 2021 19:33:36 +0300 [thread overview]
Message-ID: <YLZhYMUSxNe1JEmQ@protected.localdomain> (raw)
In-Reply-To: <87fsy1y97e.fsf@web.de>
* Michael Heerdegen <michael_heerdegen@web.de> [2021-06-01 17:03]:
> Jean Louis <bugs@gnu.support> writes:
>
> > (defmacro when-tabulated-id (table &rest body)
> > (declare (indent 2) (debug t))
> > ;;(ignore id)
> > `(if id
> > (progn
> > ,@body)
> > (if (or (eq ,table 'any)
> > (string-equal ,table rcd-current-table))
> > (let ((id (tabulated-list-get-id)))
> > (if id
> > (progn ,@body)
> > (message "Did not get ID")))
> > (message "This function is for table `%s' only" ,table))))
>
> Yes, better.
>
> The downside now is that using the macro hides the fact that the code
> depends on the id, and the resulting code is (still) hard to understand.
> Why don't you consider to make the id a real argument?
I wish I could fully understand but I don't, and I consider your
advises important.
How would I make the ID a real argument?
Each of those functions has &optional id as if function is not
capturing ID from tabulated-list-mode then it may receive it
programmatically.
Example:
(defun hyperscope-new-appointment (&optional id)
"Add new `Appointment' hyperdocument."
(interactive)
(when-tabulated-id "hyobjects"
(let ((parent (hlink-parent id)))
(hyperscope-add-new-appointment-hyperdocument parent))))
--
Jean
Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns
Sign an open letter in support of Richard M. Stallman
https://stallmansupport.org/
next prev parent reply other threads:[~2021-06-01 16:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 22:48 Why is defun not executed during load-file? Drew Adams
2021-05-30 22:57 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-31 2:05 ` [External] : " Drew Adams
2021-05-31 2:56 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-31 5:05 ` Drew Adams
2021-05-31 19:20 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-31 19:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-31 20:09 ` Marcin Borkowski
2021-06-07 2:19 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-07 6:27 ` Jean Louis
2021-06-07 14:18 ` FW: " Drew Adams
2021-06-07 14:41 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-31 21:40 ` Example use of macro to minimize and generalize the code Jean Louis
2021-05-31 23:37 ` Michael Heerdegen
2021-05-31 23:59 ` Jean Louis
2021-06-01 0:34 ` Michael Heerdegen
2021-06-01 0:39 ` Jean Louis
2021-06-01 0:59 ` Michael Heerdegen
2021-06-01 1:25 ` Jean Louis
2021-06-01 14:02 ` Michael Heerdegen
2021-06-01 16:33 ` Jean Louis [this message]
2021-06-01 16:54 ` Yuri Khan
2021-06-01 17:24 ` Jean Louis
2021-06-01 17:57 ` Yuri Khan
2021-06-01 18:12 ` Jean Louis
2021-05-31 21:45 ` Example use of macro to minimize and generalize the code (2) Jean Louis
2021-05-31 21:48 ` [External] : Re: Why is defun not executed during load-file? Michael Heerdegen
2021-05-31 23:41 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLZhYMUSxNe1JEmQ@protected.localdomain \
--to=bugs@gnu.support \
--cc=help-gnu-emacs@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.