all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jean Louis <bugs@gnu.support>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Why is defun not executed during load-file?
Date: Sun, 30 May 2021 18:36:33 +0300	[thread overview]
Message-ID: <YLOxAUiNMOql6/yj@protected.localdomain> (raw)
In-Reply-To: <jwvzgwcxsdj.fsf-monnier+emacs@gnu.org>

* Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> [2021-05-30 16:32]:
> Jean Louis [2021-05-30 12:02:25] wrote:
> > I have this in the hyperscope.el and upon load-file the last function
> > is not executed, it does not generate the functions. But if I evaluate
> > it specifically, it generates functions.
> >
> > Is there any reason for that?
> >
> > (defun hyperscope-generate-the-add-function-by-hyperdocument-type (type-name id function-name)
> >   (eval `(defun ,(intern (symbol-name function-name)) ()
> 
> My crystal ball says it's punishment for using `eval` and recommends
> using macro(s) instead.  I wouldn't trust its judgment, but the
> recommendation sounds useful anyway.
> 
> BTW, `intern + symbol-name` ends up a no-op if `function-name` is
> already an interned symbol.

I just did not find a way to make it working. Now I have put more care
and I got this to work:

(defmacro hyperscope-generate-the-add-function-by-hyperdocument-type (type-name id function-name)
  (list 'defun function-name '()
	(format "Add new `%s' hyperdocument to Hyperscope." type-name)
	'(interactive)
	'(let* ((parent (hyperscope-select-set))
		(prompt ,(format "New `%s' hyperdocument name: " type-name))
		(name (read-from-minibuffer prompt)))
	   (hlink-add-generic name "" ,id parent nil))))

(defun hyperscope-generate-add-functions-by-hyperdocument-types ()
  (let ((types (hyperscope-hyperdocument-types)))
    (while types
      (let* ((type (pop types))
	     (id (nth 0 type))
	     (type (nth 1 type))
	     (type-name type)
	     (type (downcase (string-replace " " "-" type)))
	     (function-name (format "hyperscope-add-new-%s-hyperdocument" type)))
	(insert "\n" type-name " " id " " function-name)
	(hyperscope-generate-the-add-function-by-hyperdocument-type type-name id function-name)))))

(hyperscope-generate-add-functions-by-hyperdocument-types)

Now, this does not use `eval' and generates functions when I evaluate
it.

But again it will not generate functions when I load the file.

Is that supposed to be so?

This is smallest example:

(defmacro my-generate-function (name)
  (list 'defun (intern name) '()
	"My function"
	'(interactive)
	'(message "hello")))

(my-generate-function "my-hello3")

and that example works well, it does generate function `my-hello3' but
my above doesn't.

On the other hand I have observed if I do just one time:

(fmakunbound 'hyperscope-add-new-markdown-hyperdocument)

then this function will never be generated again in the same
instance. I have to run another instance to be able to generate that
function.

Do you know why is that?


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

Sign an open letter in support of Richard M. Stallman
https://stallmansupport.org/



  reply	other threads:[~2021-05-30 15:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  9:02 Why is defun not executed during load-file? Jean Louis
2021-05-30 13:31 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-30 15:36   ` Jean Louis [this message]
2021-05-30 16:32     ` Stefan Monnier
2021-05-30 19:56       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-30 21:46         ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-30 21:55           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-30 19:44 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-30 21:56   ` Jean Louis
2021-05-30 22:07     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-30 22:39       ` Jean Louis
2021-05-30 23:26         ` Michael Heerdegen
2021-05-30 23:37           ` Jean Louis
  -- strict thread matches above, loose matches on Subject: below --
2021-05-30 22:48 Drew Adams
2021-05-30 22:57 ` Emanuel Berg via Users list for the GNU Emacs text editor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLOxAUiNMOql6/yj@protected.localdomain \
    --to=bugs@gnu.support \
    --cc=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.