all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: Illia Ostapyshyn <ilya.ostapyshyn@gmail.com>, 48406@debbugs.gnu.org
Subject: bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS)
Date: Sat, 15 May 2021 23:47:18 +0100	[thread overview]
Message-ID: <YKBPdtYQspvSFNz7@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2y2cf3hpf.fsf@gmail.com>

On Sat, May 15, 2021 at 10:44:28PM +0300, Andrii Kolomoiets wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> > Now I've dug out my Mac I can confirm I see this hang as well.
> >
> > The problem is that we never reach the NS run loop and therefore
> > windowDidEnterFullScreen is never called.
> >
> > This fixes it for me, but whether it's a good idea or not I don't know:
> >
> > -      wait_reading_process_output (0, 300000000, 0, 1, Qnil, NULL, 0);
> > +      [NSApp run];
> 
> I really like this change.  Using `wait_reading_process_output` to wait
> for NS event was a bad idea.
> 
> Though I don't understand why my setup isn't affected by this bug.

I can only guess that for some reason your setup doesn't have these
pending inputs that block ns_select. But even so I don't really
understand what's going on as I thought if there were pending inputs
then ns_read_socket would be called and clear them...

> Alan, please install your patch.

You know, I'm probably being stupid, but I can't for the life of me
remember why we need to wait for the fullscreen transition to
complete. I *thought* it was because we had a crash if we didn't, but
if I remove the wait it all works just fine...

It could be that it's pure chance I'm not seeing any problems, or that
some other fix has fixed the crash, or that the older drawing scheme
used before 10.14 has a problem and the new one doesn't... Or
something else. Do you have any idea?

I *do* remember that there was a pause required for the non-native
fullscreen due to a crash, and I don't think that will have changed,
except that I don't think I've heard from anyone still using 10.6 for
a couple of years now.
-- 
Alan Third





  reply	other threads:[~2021-05-15 22:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 20:39 bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS) Illia Ostapyshyn
2021-05-13 21:15 ` Alan Third
2021-05-14  6:07   ` Andrii Kolomoiets
2021-05-14  9:13     ` Illia Ostapyshyn
2021-05-14 19:32       ` Andrii Kolomoiets
2021-05-14 20:34         ` Alan Third
2021-05-15 19:44           ` Andrii Kolomoiets
2021-05-15 22:47             ` Alan Third [this message]
2021-05-16 20:09               ` Andrii Kolomoiets
2021-05-26 20:26                 ` Alan Third
2021-05-26 20:28                   ` Alan Third
2021-06-05 13:45                 ` Alan Third
2021-06-05 16:21                   ` Illia Ostapyshyn
2021-06-05 16:33                     ` Alan Third
2021-06-09 21:01                       ` Alan Third
2021-05-14 22:53         ` Filipp Gunbin
2021-05-15  8:34         ` Illia Ostapyshyn
2021-05-14  6:22 ` Eli Zaretskii
2021-05-14  9:22   ` Illia Ostapyshyn
2021-05-14 10:55     ` Eli Zaretskii
2021-05-14 11:09       ` Illia Ostapyshyn
2021-05-14 11:13         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKBPdtYQspvSFNz7@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=48406@debbugs.gnu.org \
    --cc=andreyk.mad@gmail.com \
    --cc=ilya.ostapyshyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.