From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#48249: 28.0.50; Regression: emacs confused about window configuration due to ido-mode and/or winner-mode Date: Fri, 7 May 2021 12:43:16 +0000 Message-ID: References: <87zgx8wmew.fsf@secretsauce.net> <87im3wm4cp.fsf@tcd.ie> <9d2af8183143b4650b2a@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6122"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , acm@muc.de, 48249@debbugs.gnu.org, Dima Kogan To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 14:54:35 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf003-0001U2-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 14:54:35 +0200 Original-Received: from localhost ([::1]:36492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf002-0007VN-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 08:54:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lezpp-00066k-V8 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lezpp-00016m-LT for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lezpp-0006Lb-IQ for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48249 X-GNU-PR-Package: emacs Original-Received: via spool by 48249-submit@debbugs.gnu.org id=B48249.162039140524370 (code B ref 48249); Fri, 07 May 2021 12:44:01 +0000 Original-Received: (at 48249) by debbugs.gnu.org; 7 May 2021 12:43:25 +0000 Original-Received: from localhost ([127.0.0.1]:43665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezpF-0006L0-Ab for submit@debbugs.gnu.org; Fri, 07 May 2021 08:43:25 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:14602 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lezpE-0006Ks-1O for 48249@debbugs.gnu.org; Fri, 07 May 2021 08:43:24 -0400 Original-Received: (qmail 59140 invoked by uid 3782); 7 May 2021 12:43:17 -0000 Original-Received: from acm.muc.de (p4fe15bd7.dip0.t-ipconnect.de [79.225.91.215]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 07 May 2021 14:43:16 +0200 Original-Received: (qmail 6631 invoked by uid 1000); 7 May 2021 12:43:16 -0000 Content-Disposition: inline In-Reply-To: <9d2af8183143b4650b2a@heytings.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205925 Archived-At: Hello, Gregory. On Fri, May 07, 2021 at 12:02:14 +0000, Gregory Heytings wrote: > > > > diff --git a/lisp/winner.el b/lisp/winner.el > > index f30fa6cf5c..a60ef44662 100644 > > --- a/lisp/winner.el > > +++ b/lisp/winner.el > > @@ -212,7 +212,7 @@ winner-set-conf > > (minisize (window-height miniwin))) > > (cl-letf (((window-buffer miniwin)) > > ((window-point miniwin))) > > - (set-window-configuration winconf)) > > + (set-window-configuration winconf nil t)) > > (cond > > ((window-live-p chosen) (select-window chosen)) > > ((window-minibuffer-p) (other-window 1))) > > > This cannot be the right way to fix the bug. That line was last changed > more than 20 years ago (commit 2a92dc2540 by RMS). I agree it isn't the best way to fix the bug, because that fix isn't robust enough. But it's hopefully good enough to relieve the irritation of the original poster for a short while, while I work on something better. It's also good enough to check whether the cause of the bug has actually been found. That the source line was last changed so long ago is neither here nor there. > Or does that mean that from now on each occurrence of > 'set-window-configuration' (there are 98 occurrences in the Emacs core > only) should take an additional dont-set-miniwindow t argument to avoid > that bug? That is the problem. Some of these calls might need the extra argument, most of them won't. Such a requirement would be a poor abstraction, since the typical caller of set-window-configuration shouldn't have to worry about such details. By the way, thanks for the service you're providing of identifying bugs connected with the recent minibuffer changes. It's appreciated! -- Alan Mackenzie (Nuremberg, Germany).