From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Problem with cl-letf in winner.el Date: Thu, 6 May 2021 16:42:43 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40604"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 06 19:12:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lehYG-000ARl-NG for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 19:12:40 +0200 Original-Received: from localhost ([::1]:54456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lehYF-0003gd-O1 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 13:12:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leh5N-00080v-BB for emacs-devel@gnu.org; Thu, 06 May 2021 12:42:49 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:32573 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1leh5L-0003BX-CT for emacs-devel@gnu.org; Thu, 06 May 2021 12:42:49 -0400 Original-Received: (qmail 21600 invoked by uid 3782); 6 May 2021 16:42:44 -0000 Original-Received: from acm.muc.de (p4fe15eae.dip0.t-ipconnect.de [79.225.94.174]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 06 May 2021 18:42:44 +0200 Original-Received: (qmail 1565 invoked by uid 1000); 6 May 2021 16:42:43 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268980 Archived-At: Hello, Emacs. In Emacs master branch: In connection with bug #48249, I'm looking at winner.el. In function winner-set-conf, there is the following macro call: (cl-letf (((window-buffer miniwin)) ((window-point miniwin))) (set-window-configuration winconf)) .. I'm having trouble understanding it. When I expand and pretty print it, I get this: (let* ((v miniwin) (v miniwin) (old (window-point v)) (old (window-buffer v))) (unwind-protect (set-window-configuration winconf) (set-window-point v old) (let* ((v old)) (progn (set-window-buffer v v) v)))) This looks very strange indeed: under the let* there are two variables called v and two variables called old. This looks like a bug to me, but alternatively, is there something I'm not understanding here? (Just to be specific, I expanded the macro with lexical-binding both nil and t, and got the same results.) Help, please! -- Alan Mackenzie (Nuremberg, Germany).