From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Control of fan-speed on Lenovo Thinkpads Date: Thu, 1 Apr 2021 12:46:00 +0300 Message-ID: References: <87blb13vr8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.6 (2021-03-06) Cc: help-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 01 11:48:35 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRtwJ-000AAm-3W for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 01 Apr 2021 11:48:35 +0200 Original-Received: from localhost ([::1]:50910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRtwI-0007l8-2T for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 01 Apr 2021 05:48:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRtvj-0007kx-I0 for help-gnu-emacs@gnu.org; Thu, 01 Apr 2021 05:47:59 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:59065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRtve-0004cN-QQ for help-gnu-emacs@gnu.org; Thu, 01 Apr 2021 05:47:58 -0400 Original-Received: from localhost ([::ffff:41.202.241.58]) (AUTH: PLAIN securesender, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000001E1DB.00000000606596C5.00001F9D; Thu, 01 Apr 2021 02:47:48 -0700 Mail-Followup-To: Stefan Monnier , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128798 Archived-At: * Stefan Monnier [2021-03-31 23:20]: > > * Stefan Monnier [2021-03-31 17:24]: > >> > (let* ((sudo `(call-process "sudo" nil ,sudo-buffer t "su" "-c" "--" "root" "-c" ,command)) > >> > (status (eval sudo)) > >> > >> Why? No kitten needs to suffer here: > >> > >> (let* ((status (call-process "sudo" nil sudo-buffer t "su" "-c" "--" "root" "-c" command)) > > > > In that specific case yes. It works, I changed it. But it defeats > > itself in purpose, do you see? That COMMAND is parameter to `su' which > > invokes default user's shell. I don't find it bad, it just defeats the > > purpose of `call-process'. > > You still have the risk of "command" being incorrect because of > messed up quoting, but not because of the shell you yourself invoke: just > because of the shell invoked by `su`. And since "command" is what you > receive you can't do much better than that anyway. Thank you. The lesson is more important than this particular `sudo' function. As now I have to improve other 158 functions with `shell-command' for safety of quoting. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://rms-support-letter.github.io/