From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Control of fan-speed on Lenovo Thinkpads Date: Wed, 31 Mar 2021 23:02:46 +0300 Message-ID: References: <87blb13vr8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.6 (2021-03-06) Cc: help-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 31 22:08:24 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRh8a-0007gU-NG for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 22:08:24 +0200 Original-Received: from localhost ([::1]:47206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRh8Z-00065Q-Nj for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 16:08:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRh89-00065B-JA for help-gnu-emacs@gnu.org; Wed, 31 Mar 2021 16:07:57 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:35429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRh83-0002fA-KC for help-gnu-emacs@gnu.org; Wed, 31 Mar 2021 16:07:56 -0400 Original-Received: from localhost ([::ffff:41.202.241.58]) (AUTH: PLAIN securesender, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000001E1D1.000000006064D694.0000538E; Wed, 31 Mar 2021 13:07:47 -0700 Mail-Followup-To: Stefan Monnier , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128796 Archived-At: * Stefan Monnier [2021-03-31 17:24]: > > (let* ((sudo `(call-process "sudo" nil ,sudo-buffer t "su" "-c" "--" "root" "-c" ,command)) > > (status (eval sudo)) > > Why? No kitten needs to suffer here: > > (let* ((status (call-process "sudo" nil sudo-buffer t "su" "-c" "--" "root" "-c" command)) In that specific case yes. It works, I changed it. But it defeats itself in purpose, do you see? That COMMAND is parameter to `su' which invokes default user's shell. I don't find it bad, it just defeats the purpose of `call-process'. On the other hand, something like this would not work: (call-process "dmesg" nil (get-buffer-create "*out*") t "-l info") → 1 with message "dmesg: unknown level ' info'" but this works: (call-process "dmesg" nil (get-buffer-create "*out*") t "-l" "info") → 0 Maybe `call-process' is not that much safer than `shell-command', as with some dangerous arguments it could execute wrongly. I find it beneficial that one can forget about quoting. (call-process "echo" nil (get-buffer-create "*out*") t "-n" "Hello there") → 0 -- works well even with new line. (call-process "echo" nil (get-buffer-create "*out*") t "-n" "Hello \"there\" 'Somebody here' and ''' more than that.") → 0 with message: Hello "there" 'Somebody here' and ''' more than that. For me it brings main benefit that I can forget about problems of quoting. I will be replacing `shell-command' in those functions where quoting is possible problem. Example would be here, where `figlet' accepts strings but then with `shell-command' I would need to take care of proper quoting. (defvar figlet-history nil) (defvar figlet-font-history nil) (defun figlet () (interactive) (let* ((fonts '("banner" "big" "block" "bubble" "digital" "ivrit" "lean" "mini" "mnemonic" "script" "shadow" "slant" "small" "smscript" "smshadow" "smslant" "standard" "term")) (font (completing-read "Font: " fonts nil t (car figlet-font-history) 'figlet-font-history)) (text (read-from-minibuffer "Text: " (car figlet-history) nil nil 'figlet-history)) (command (format "figlet -f %s \"%s\"" font text)) (figlet (shell-command-to-string command))) (if buffer-read-only (message figlet) (insert figlet)))) Then such can be improved so that programmer does not think of quoting: (defun figlet () (interactive) (let* ((fonts '("banner" "big" "block" "bubble" "digital" "ivrit" "lean" "mini" "mnemonic" "script" "shadow" "slant" "small" "smscript" "smshadow" "smslant" "standard" "term")) (font (completing-read "Font: " fonts nil t (car figlet-font-history) 'figlet-font-history)) (text (read-from-minibuffer "Text: " (car figlet-history) nil nil 'figlet-history))) (call-process "figlet" nil t nil "-f" font text))) Where one can insert any kind of quotes in the string: +-+-+-+-+-+-+-+ +-+-+-+-+-+ |"|t|h|a|n|k|"| |"|y|o|u|"| +-+-+-+-+-+-+-+ +-+-+-+-+-+ or +-+-+-+-+-+-+ +-+-+ +-+-+-+-+-+-+-+-+ +-+-+ +-+-+ +-+-+-+-+-+ +-+-+-+ +-+ |'|'|T|h|i|s| |i|s| |'|'|F|u|n|n|y|'| |\|'| |i|t| |w|o|r|k|s| |a|l|l| |-| +-+-+-+-+-+-+ +-+-+ +-+-+-+-+-+-+-+-+ +-+-+ +-+-+ +-+-+-+-+-+ +-+-+-+ +-+ +-+-+-+-+-+-+-+-+-+-+ |||@|\|"|n|i|c|e|\|"| +-+-+-+-+-+-+-+-+-+-+ -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://rms-support-letter.github.io/