Re: Better way to make sure external command exists in the system?

[Jean Louis <bugs@gnu.support>]

* Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> [2021-03-25 18:04]:
> Jean Louis wrote:
> 
> > Now it is:
> >
> > (defvar image-default-resize-size "1536")
> > (defvar image-resize-sizes '("1536" "1024" "800" "1200" "640"))
> 
> Well, the width of a computer image is not a string but
> an integer.

Maybe yes, maybe not, but it does not matter neither for human or
computer. Human sees the number at completion.

> > Maybe it works with numbers, but now I changed it to
> > completing-read, maybe that is why I placed it as strings.
> 
> Don't do that, data should be in its natural, sound state,
> then it is up to functions and/or users who use it to convert
> it to fit their purposes. And the better everything is, the
> less of that is required.

In general yes, but in this specific case, who cares, important is
that it works. Numbers or strings are converted to string by using
format. One can supply either integer or string, it does not matter,
it works. See:

(defun image-resize (file &optional size)
  "Resizes the JPG image with default SIZE.
Argument FILE is image to be resized."
  (if (rcd-which-list '("mogrify"))
      (let ((extension (file-name-extension file)))
	(when (or (equal (downcase extension) "jpg")
		  (equal (downcase extension) "png"))
	  (let* ((file (shell-double-quote file))
		 (command (format "mogrify -resize %s \"%s\"" size file)))
	    (message command)
	    (call-process-shell-command command))))
    (rcd-warning-message "RCD ERROR: `mogrify' not found in `$PATH'")))

> > (defun image-resize-dired ()
> >   "Resizes images."
> >   (interactive)
> >   (let ((files (dired-get-marked-files))
> > 	(size (completing-read "Size: " image-resize-sizes nil t image-default-resize-size)))
> >     (dolist (file files)
> >       (image-resize file size))
> >     (revert-buffer)))
> >
> > That way is better, my choice of 1536 is offered, but if
> > I delete it, I can complete it with some of other default
> > choices. It is very handy to mark files and resize them how
> > one wants.
> 
> OK, not sure that's the way it is supposed to work but if you
> want to innovate, no problem.

I want to be able to complete straight. `read-number' does not offer
completion.

This does not work:

(completing-read "Number: " '(1 2 3))

This works:

(completing-read "Number: " '("1" "2" "3"))

Now you get it why they are strings in the completion list? They are
not strings for the underlying function `image-resize' but only for
the completion candidates.

> Otherwise looks good, I don't have dired-get-marked-files,

It is in dired.

> rcd-warning-message, rcd-which-list, or shell-double-quote but
> I suppose you do...

I gave you recently if you need.

> >> Also, why `read-number' and not in interactive?
> >
> > I often use `completing-read', maybe that may be implemented in
> > `interactive' but I don't find it nice that way.
> 
> Yes, compare:
> 
> (interactive
>   `(,(string-to-number
>        (completing-read "Digit: " '("11" "12" "13") nil t "11"))))

That would mean if I change candidates list I would actually need to
change the function. Not practical. 🙈 But interesting.

> >> And, no need for globals if they are only used here.
> >> Use let* for that as well.
> >
> > Which globals?
> 
> The two global variables.

I would not know which...