all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 47320@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#47320: Improve failure reporting in test/lisp/electrict-tests.el
Date: Tue, 23 Mar 2021 14:47:41 +0000	[thread overview]
Message-ID: <YFn/jUc7UYnK+4Xe@ACM> (raw)
In-Reply-To: <87v99i5k0f.fsf@gmx.de>

Hello, Michael.

On Tue, Mar 23, 2021 at 09:53:04 +0100, Michael Albinus wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > Hello, Emacs.

> Hi Alan,

> > My proposal is that on a test failure, this generated doc-string should
> > be output along with the other failure stuff.  It doesn't actually add
> > all that much bulk to the .log file.

> > Here is patch which does this.  If there are no objections, I will
> > commit it in a day or two.

> There is the explainer functionality in ert, see

> (info "(ert)Defining Explanation Functions")

That description is rather terse.  In fact it is incomplete - it does
not say when the explanation function gets called, nor does it say what
is done with any resulting explanation.

It looks like a explanation function needs to duplicate the test code of
the test being explained - it seems the function has no access to the
internal state of the test.

I only wish to print the extra information when there is a test failure.
Otherwise the information in electric-tests.log would be swamped by
pointless voluminous doc strings.

Or am I missing something?

> I recommend to use it, for better readability of the test code. Examples
> are in our test files.

Thanks!

> Best regards, Michael.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2021-03-23 14:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 14:24 bug#47320: Improve failure reporting in test/lisp/electrict-tests.el Alan Mackenzie
2021-03-23  8:53 ` Michael Albinus
2021-03-23 14:47   ` Alan Mackenzie [this message]
2021-03-23 15:24     ` Michael Albinus
2021-03-23 15:59       ` João Távora
2021-03-24 13:46         ` Alan Mackenzie
2021-03-24 14:02           ` João Távora
2021-03-24 19:42             ` Alan Mackenzie
2021-03-24 20:10               ` João Távora
2021-03-25 13:43                 ` Alan Mackenzie
2021-03-25 23:47                   ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFn/jUc7UYnK+4Xe@ACM \
    --to=acm@muc.de \
    --cc=47320@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.