From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#47094: 27.1; emacs dies with XBM display Date: Sat, 13 Mar 2021 22:07:14 +0000 Message-ID: References: <86czw4hdxn.fsf@gmail.com> <83ft10lf0j.fsf@gnu.org> <83im5vjzbe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25835"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ynyaaa@gmail.com, 47094@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 13 23:08:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLCQn-0006fG-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 23:08:21 +0100 Original-Received: from localhost ([::1]:54492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLCQm-00027i-UL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 17:08:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLCQV-00027T-09 for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 17:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLCQU-0003yX-Nv for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 17:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLCQU-0001KL-I8 for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 17:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Mar 2021 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47094 X-GNU-PR-Package: emacs Original-Received: via spool by 47094-submit@debbugs.gnu.org id=B47094.16156732525065 (code B ref 47094); Sat, 13 Mar 2021 22:08:02 +0000 Original-Received: (at 47094) by debbugs.gnu.org; 13 Mar 2021 22:07:32 +0000 Original-Received: from localhost ([127.0.0.1]:60865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLCPz-0001Jd-RT for submit@debbugs.gnu.org; Sat, 13 Mar 2021 17:07:32 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:59641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLCPv-0001JN-L2 for 47094@debbugs.gnu.org; Sat, 13 Mar 2021 17:07:30 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id D79D0600D0; Sat, 13 Mar 2021 22:07:21 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1615673241; bh=4nPSj3ZOwUeZG4J4TMzGyIfbFn1LzXypHQ+Bu/6Q6hQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/HfATcs52yR7+D8l66VNAmTWy/UChkF0RPrmzQJuignS0yfk1QmKkeB5JCb5D4OT fwAyC5qKHbT1HLPR3owoqdlWKmR0BX73cZcLWcq9MH3JgG1w4GO2dafo454sXp1jTn XR+pWyCKLB2K2kN+2/1U24CVkeYe9dr+aGIycxslbTd/4YJ71r5wGDe2NzIUFelXQK NvevKN74PW9pCThn0ZRCbatiQ+d0D3PUWUo9z7MAqrjsAr3A/xTc8mU6+rZTpAWgKO 0rjdeHGhbNJ/8YGdRIfqZE1+kiaep9nBGauiHeFpUQlDzSlcnXo6YBp+J5aNaFZF6R GiO6IJ+l3boLA== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id BF105202AF2123; Sat, 13 Mar 2021 22:07:14 +0000 (GMT) Mail-Followup-To: Alan Third , Eli Zaretskii , ynyaaa@gmail.com, 47094@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <83im5vjzbe.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202315 Archived-At: On Sat, Mar 13, 2021 at 09:19:17AM +0200, Eli Zaretskii wrote: > > Date: Fri, 12 Mar 2021 22:08:10 +0000 > > From: Alan Third > > > > > > (let* ((w 256) > > > > (h 256) > > > > (s (make-string (* (/ w 8) h) #x55))) > > > > (insert-image (create-image s 'xbm t :width w :height h))) > > > > > > I can reproduce in Emacs 27, but not on the current master branch. So > > > I guess this has been fixed already, and I'm closing the bug. > > > > I can reproduce on the master branch. It looks like a stack overflow > > in xbm_read_bitmap_data. > > I did indeed get an infinite recursion on the emacs-27 branch, but not > on master. > > > I tried it in a debugger, but the backtrace looks truncated. > > Before or after SIGSEGV? If it's after, then it isn't surprising you > get a truncated backtrace. > > I think if you see the infinite recursion we should understand why it > happens in the first place, and try to prevent it. It turns out it was a buffer overflow in xbm_scan that was clobbering the stack. I've pushed a fix to the master branch. -- Alan Third