From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: goto-line-history should not be buffer local. Date: Tue, 16 Feb 2021 20:57:53 +0000 Message-ID: References: <87im6ugsdq.fsf@telefonica.net> <875z2s3s9b.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6327"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Copley , martin rudalics , =?iso-8859-1?Q?=D3scar?= Fuentes , Emacs Development To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 16 21:58:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lC7QX-0001Vt-DU for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Feb 2021 21:58:33 +0100 Original-Received: from localhost ([::1]:46326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC7QW-00074J-BT for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Feb 2021 15:58:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC7Q0-0006Yg-Cx for emacs-devel@gnu.org; Tue, 16 Feb 2021 15:58:00 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:25594 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lC7Py-0000QP-5k for emacs-devel@gnu.org; Tue, 16 Feb 2021 15:58:00 -0500 Original-Received: (qmail 11750 invoked by uid 3782); 16 Feb 2021 20:57:54 -0000 Original-Received: from acm.muc.de (p4fe15a74.dip0.t-ipconnect.de [79.225.90.116]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 16 Feb 2021 21:57:53 +0100 Original-Received: (qmail 8944 invoked by uid 1000); 16 Feb 2021 20:57:53 -0000 Content-Disposition: inline In-Reply-To: <875z2s3s9b.fsf@mail.linkov.net> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264938 Archived-At: Hello, Juri. On Tue, Feb 16, 2021 at 19:13:36 +0200, Juri Linkov wrote: > > -(defvar-local goto-line-history nil > > +(defcustom goto-line-history-local nil > > + "If this option is nil, `goto-line-history' is shared between all buffers. > > +if it is non-nil, each buffer has its own value of this history list. > > + > > +Note that on changing from non-nil to nil, the former contents of > > +`goto-line-history' for each buffer are discarded on use of > > +`goto-line' in that buffer." > > + :group 'editing > > + :type 'boolean > > + :safe #'booleanp > > + :version "28.1") > > Anybody have any objections to this? > This is not an objection, just sharing a tip that to make > Isearch history buffer-local like it's in web browsers, > where each web page tab uses own local search history, > is possible with a small code snippet: > (make-variable-buffer-local 'search-ring) > (make-variable-buffer-local 'regexp-search-ring) > OTOH, with using defcustom it's easier to customize this, indeed. The point about the approach I've taken is that once a variable has undergone make-variable-buffer-local, it cannot be changed back to a non-local variable, except by restarting Emacs (I'm not sure whether or not this is a design bug). So I've avoided the use of that primitive. -- Alan Mackenzie (Nuremberg, Germany).