From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Date: Sun, 14 Feb 2021 10:03:25 +0000 Message-ID: References: <871rdksz8x.fsf@tcd.ie> <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10346"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 46491@debbugs.gnu.org To: Yuuki Harano Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 11:04:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBEGR-0002Xe-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 11:04:27 +0100 Original-Received: from localhost ([::1]:59908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBEGO-0001mq-NP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 05:04:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBEG2-0001mb-G5 for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 05:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBEG2-0000xs-8o for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 05:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBEG2-0007If-52 for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 05:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46491-submit@debbugs.gnu.org id=B46491.161329701728029 (code B ref 46491); Sun, 14 Feb 2021 10:04:02 +0000 Original-Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 10:03:37 +0000 Original-Received: from localhost ([127.0.0.1]:35448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBEFd-0007I1-1G for submit@debbugs.gnu.org; Sun, 14 Feb 2021 05:03:37 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:55161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBEFa-0007Hm-El for 46491@debbugs.gnu.org; Sun, 14 Feb 2021 05:03:35 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 5A375600D0; Sun, 14 Feb 2021 10:03:28 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1613297007; bh=/I3jpSGK+RuuvOekVTVaxAx9pdhD32/aJ30R/fp25SU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fufVePoNNUpDphTMDhNmmEuekz0YHeb9lBqC10jj+qYrKgNG3yyx4L7v3PjeKMU1X UnAITA6haLDicGhpuiU6KeqluwVpM7d8uFn+3RSGOmrqXLg2qgJb+0UGr1uWCyt3oR +2TvNGeOgyfd5R3smjrPfvza6aEwmy2dpocVQ1lkwUdQqb/p7mDZ/SweizcjrOGWfU CNcLPV4ICEwduR2fW9L4LhyOlJ3ZK/v6CnnTjECOIINSglLC+8+BF62+4ZBauYeHzl X03IoELe93enxpupeYnj0GbrCk4uxmw+pzzf6h/Utq3kRY3n8mT4kqzGpI0MQSNDln JZeug44dMLuZQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A8C67202A6E2FF; Sun, 14 Feb 2021 10:03:25 +0000 (GMT) Mail-Followup-To: Alan Third , Yuuki Harano , contovob@tcd.ie, 46491@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199989 Archived-At: On Sun, Feb 14, 2021 at 11:20:19AM +0900, Yuuki Harano wrote: > > On Sat, 13 Feb 2021 23:05:45 +0000, > Alan Third wrote: > > I think your patch looks right, but I'm confused as to why this is in > > the PGTK branch at all. The imagemagick transforms are intentionally > > excluded from the native transforms, but this disables the imagemagick > > transforms completely and, presumably, replaces them with native > > transforms. > > I wanted to make imagemagick images not blurry in image-mode on > scale x2.0 monitor. > > With the exclusion, imagemagick generates scaled image pixel data, > and the image is rendered twice in size, so it is blurry. > Without the exclusion, imagemagick generates original image pixel data, > and the image may not be enlarged (but shrinked), so it may not be blurry. > > For other than imagemagick, like png, original image pixel data is generated, > and it is not blurry on scale x2.0 monitor. I am aware of this, I see the same thing on NS, but when native transforms were introduced we decided that when a user asks imagemagick to modify an image, imagemagick should actually do the modifications and Emacs will just display the results. I don't know that it's important, though. -- Alan Third