From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Date: Sat, 13 Feb 2021 23:05:45 +0000 Message-ID: References: <871rdksz8x.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yuuki harano , 46491@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 00:06:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB3zO-0008XZ-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 00:06:10 +0100 Original-Received: from localhost ([::1]:34854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB3zN-0004o4-D3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 18:06:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB3zG-0004nv-Tk for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 18:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB3zG-0000t3-MX for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 18:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lB3zG-0008Gq-GV for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 18:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Feb 2021 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46491-submit@debbugs.gnu.org id=B46491.161325755831780 (code B ref 46491); Sat, 13 Feb 2021 23:06:02 +0000 Original-Received: (at 46491) by debbugs.gnu.org; 13 Feb 2021 23:05:58 +0000 Original-Received: from localhost ([127.0.0.1]:35205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB3zC-0008GW-Io for submit@debbugs.gnu.org; Sat, 13 Feb 2021 18:05:58 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:49971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB3z9-0008GI-7E for 46491@debbugs.gnu.org; Sat, 13 Feb 2021 18:05:57 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 0BE8E600D0; Sat, 13 Feb 2021 23:05:49 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1613257548; bh=HgioaTr4FAl7GTt/0pkHUdP9i/ZdFNQ58/F3S8HAumo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OZWAKutDDNQYU2eE+0At9CPpTUhioyu1Sb3ImVDiFa3iomi2SfejzNAoPKBWUe9pj JI7Aq9iXzPgKiJjgCPkaDzpqdZsG48mC0aJE4afPwenJN03C7rNgVfJFBuUdntasjd PZ/o13HZOQMcatrE6DKSrzL5eVrlBy/NKLq5pn7PZGq/ctmcYJdsPTeJHcqsF0fxVV J1Bmjo3w9TN9bej8a53gDp8AhG+vMm4R2jaoK7qdedQiDa4rQzm0jrVuBIm9u+7Lxp DsGMAHNOwPxeIwZj1jQY/0X13v7CTrwZLY2+PxhI8uCF5vqOBtIClw8rK2o1qXtwnC hvmGYi/sB0DXQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id B558B202A6D446; Sat, 13 Feb 2021 23:05:45 +0000 (GMT) Mail-Followup-To: Alan Third , "Basil L. Contovounesios" , 46491@debbugs.gnu.org, yuuki harano Content-Disposition: inline In-Reply-To: <871rdksz8x.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199967 Archived-At: On Sat, Feb 13, 2021 at 04:34:22PM +0000, Basil L. Contovounesios wrote: > X-Debbugs-Cc: Yuuki Harano > Severity: minor > Tags: patch > > The following is the only build warning I currently get on feature/pgtk: > > image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE" > is not used [-Wunused-macros] > 110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE > > Is the attached patch the right fix? If so, I can push it after adding > the bug#number to it. I think your patch looks right, but I'm confused as to why this is in the PGTK branch at all. The imagemagick transforms are intentionally excluded from the native transforms, but this disables the imagemagick transforms completely and, presumably, replaces them with native transforms. -- Alan Third