From: Alan Third <alan@idiocy.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: yuuki harano <masm+emacs@masm11.me>, 46491@debbugs.gnu.org
Subject: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick
Date: Sat, 13 Feb 2021 23:05:45 +0000 [thread overview]
Message-ID: <YChbSe/CaSiSn1+o@breton.holly.idiocy.org> (raw)
In-Reply-To: <871rdksz8x.fsf@tcd.ie>
On Sat, Feb 13, 2021 at 04:34:22PM +0000, Basil L. Contovounesios wrote:
> X-Debbugs-Cc: Yuuki Harano <masm+emacs@masm11.me>
> Severity: minor
> Tags: patch
>
> The following is the only build warning I currently get on feature/pgtk:
>
> image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE"
> is not used [-Wunused-macros]
> 110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE
>
> Is the attached patch the right fix? If so, I can push it after adding
> the bug#number to it.
I think your patch looks right, but I'm confused as to why this is in
the PGTK branch at all. The imagemagick transforms are intentionally
excluded from the native transforms, but this disables the imagemagick
transforms completely and, presumably, replaces them with native
transforms.
--
Alan Third
next prev parent reply other threads:[~2021-02-13 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 16:34 bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Basil L. Contovounesios
2021-02-13 23:05 ` Alan Third [this message]
2021-02-14 2:20 ` Yuuki Harano
2021-02-14 10:03 ` Alan Third
2021-02-14 15:38 ` Eli Zaretskii
2021-02-14 2:02 ` Yuuki Harano
2021-02-14 12:33 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YChbSe/CaSiSn1+o@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=46491@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=masm+emacs@masm11.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.