From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, ynyaaa@gmail.com, 46556@debbugs.gnu.org
Subject: bug#46556: 27.1; transparent images are displayed incorrectly if rotated
Date: Wed, 17 Feb 2021 19:26:38 +0000 [thread overview]
Message-ID: <YC1t7osPcVt+Sk02@breton.holly.idiocy.org> (raw)
In-Reply-To: <83blci7hgd.fsf@gnu.org>
On Wed, Feb 17, 2021 at 07:05:38PM +0200, Eli Zaretskii wrote:
> > Date: Tue, 16 Feb 2021 21:24:24 +0000
> > From: Alan Third <alan@idiocy.org>
> > Cc: ynyaaa@gmail.com, 46556@debbugs.gnu.org
> >
> > > Would it be possible for you to test with Emacs 28 and see whether the
> > > problem you report (on Windows) is still present there?
> >
> > It does sound like something must be going wrong on Windows.
> > Unfortunately I don't know what that could be because, as I said on
> > the other bug report, NS and Windows use the same rotation logic, and
> > NS is fine, so it must be when it comes to actually drawing that the
> > problem manifests.
>
> I've now stepped through the code which implements rotation, and I see
> nothing wrong with the results. The pixel coordinates of the rotated
> square are exact and accurate, without any roundoff that I could spot.
> Each square starts exactly 50+8 = 58 pixels after the previous one (8
> pixels are taken by the SPC character between the squares), and ends
> exactly 50 pixels after it starts.
>
> So I have no idea why the one-pixel shift happens. Of course, I don't
> really understand what that code does (although I hacked it quite
> extensively), so maybe someone who really understands that stuff could
> take a look and tell what's wrong there.
Can either you or the OP provide a screenshot? It's not entirely clear
to me what's happening. It sounds like some of the behaviour of this
bug would be explained by the mask not being rotated with the image,
but other bits of the description don't seem to match that.
The other bug with the single pixel white line sounds more like an
off-by-one in SVG production, but you'd see that in every image, so
it's probably not that.
--
Alan Third
next prev parent reply other threads:[~2021-02-17 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 10:17 bug#46556: 27.1; transparent images are displayed incorrectly if rotated ynyaaa
2021-02-16 13:10 ` Lars Ingebrigtsen
2021-02-16 21:24 ` Alan Third
2021-02-17 17:05 ` Eli Zaretskii
2021-02-17 19:26 ` Alan Third [this message]
2021-02-17 19:57 ` bug#46554: 27.1; 180 degree rotated image is displayed in slightly different position Eli Zaretskii
2021-02-17 19:59 ` bug#46556: 27.1; transparent images are displayed incorrectly if rotated Eli Zaretskii
2021-02-17 20:07 ` Alan Third
2021-02-17 20:26 ` Eli Zaretskii
2021-02-17 21:08 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC1t7osPcVt+Sk02@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=46556@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=ynyaaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.