all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Platon Pronko <platon7pronko@gmail.com>
Cc: 45792@debbugs.gnu.org
Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file
Date: Sat, 30 Jan 2021 18:35:03 +0000	[thread overview]
Message-ID: <YBWm1/7AjYSPnhZW@ACM> (raw)
In-Reply-To: <aafdbb97-7bc3-4247-bff9-26e984174323@gmail.com>

Hello again, Platon.

Terribly sorry to take nearly two weeks to reply.  Real life got in the
way.

On Sun, Jan 17, 2021 at 10:50:32 +0300, Platon Pronko wrote:
> Hi!

> I'm terribly sorry, apparently I wasted a lot of your time.

No problem, but I don't think you did.  There were real bugs connected
with input methods, and I think your initial scenario highlighted one of
these bugs.

> I tested (minibufferp) refactoring again and it seems that when I
> did that for the previous email I messed something up. When I ran the code today
> the issue went away.

It hasn't gone away for me.  ;-)

> Original reason for " *Minibuf-0*" test in dvorak-minor-mode was to
> stop emacs --daemon from hanging on startup. (now that you explained about
> quail-minibuffer-message and sit-for, I assume that's was the reason why that was happening)

Possibly.

> But the buffer that was triggering the current issue is called " *Minibuf-1*", so it
> passes the test and activate-input-method is called.

Yes.

> I had no idea that activate-input-method was dangerous when called in
> global minor modes, but that's probably just the way it is.

I disagree.  The fact that it is dangerous is a bug which needs fixing.
The fix I have at the moment is not to call the (sit-for 1000000) when
the current buffer is a minibuffer.  To be honest, I don't understand
quail.el very well, but I'm not sure there's anybody still on the
development team who understands it any better.

> Again, terribly sorry for wasting your time on what turned out to be
> a configuration issue.

No need to apologise - there were real bugs there.  Thanks for the
original report!

> > Just as a matter of interest, you can write that more easily as
> > ./src/emacs -Q -l ~/.emacs.d/init.el.

> Thanks, that's a useful shortcut!

:-)

I'm hoping to commit a patch for the bug over the weekend, sometime.
It's been a difficult bug to diagnose.

> Best regards,
> Platon Pronko

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2021-01-30 18:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 16:09 bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Platon Pronko
2021-01-12  9:06 ` martin rudalics
2021-01-12 10:29   ` Platon Pronko
2021-01-12 19:00 ` Alan Mackenzie
2021-01-16 16:36 ` Alan Mackenzie
2021-01-17  7:50   ` Platon Pronko
2021-01-30 18:35     ` Alan Mackenzie [this message]
2021-01-31  8:54       ` Platon Pronko
2021-01-31 11:50         ` Alan Mackenzie
2021-01-31 12:11           ` Platon Pronko
2021-01-31 17:01             ` Alan Mackenzie
2021-01-31 19:37               ` Platon Pronko
2021-01-31 20:06                 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBWm1/7AjYSPnhZW@ACM \
    --to=acm@muc.de \
    --cc=45792@debbugs.gnu.org \
    --cc=platon7pronko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.