all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#46036: fails do build on macos 10.7
@ 2021-01-22 14:57 Riccardo Mottola
  2021-01-30  8:57 ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Riccardo Mottola @ 2021-01-22 14:57 UTC (permalink / raw)
  To: 46036

Compilation of 27.1 yields:
nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
   NSNumber *isUbiquitousItem = @YES;
                                 ^
/usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
#define YES             (BOOL)1
                          ^

this code is guarded with MacOS 10.7, but the compiler doesn't like it.

It is as easy to write it old-style:
   NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];

and emacs 27.1 happily running on Lion again.

Thanks






^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-22 14:57 bug#46036: fails do build on macos 10.7 Riccardo Mottola
@ 2021-01-30  8:57 ` Eli Zaretskii
  2021-01-30 10:56   ` Alan Third
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2021-01-30  8:57 UTC (permalink / raw)
  To: Riccardo Mottola, Alan Third; +Cc: 46036

> Date: Fri, 22 Jan 2021 15:57:18 +0100
> From: Riccardo Mottola <riccardo.mottola@libero.it>
> 
> Compilation of 27.1 yields:
> nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
>    NSNumber *isUbiquitousItem = @YES;
>                                  ^
> /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> #define YES             (BOOL)1
>                           ^
> 
> this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> 
> It is as easy to write it old-style:
>    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> 
> and emacs 27.1 happily running on Lion again.

Alan, any comments on this?





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-30  8:57 ` Eli Zaretskii
@ 2021-01-30 10:56   ` Alan Third
  2021-01-30 12:05     ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Alan Third @ 2021-01-30 10:56 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 46036, Riccardo Mottola

On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > From: Riccardo Mottola <riccardo.mottola@libero.it>
> > 
> > Compilation of 27.1 yields:
> > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> >    NSNumber *isUbiquitousItem = @YES;
> >                                  ^
> > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > #define YES             (BOOL)1
> >                           ^
> > 
> > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > 
> > It is as easy to write it old-style:
> >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > 
> > and emacs 27.1 happily running on Lion again.
> 
> Alan, any comments on this?

Looks fine to me. Is this good to go into Emacs 27, or does it have to
wait until the release is done?
-- 
Alan Third





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-30 10:56   ` Alan Third
@ 2021-01-30 12:05     ` Eli Zaretskii
  2021-01-30 18:32       ` Riccardo Mottola
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2021-01-30 12:05 UTC (permalink / raw)
  To: Alan Third; +Cc: 46036, riccardo.mottola

> Date: Sat, 30 Jan 2021 10:56:59 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: Riccardo Mottola <riccardo.mottola@libero.it>, 46036@debbugs.gnu.org
> 
> On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > > From: Riccardo Mottola <riccardo.mottola@libero.it>
> > > 
> > > Compilation of 27.1 yields:
> > > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> > >    NSNumber *isUbiquitousItem = @YES;
> > >                                  ^
> > > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > > #define YES             (BOOL)1
> > >                           ^
> > > 
> > > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > > 
> > > It is as easy to write it old-style:
> > >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > > 
> > > and emacs 27.1 happily running on Lion again.
> > 
> > Alan, any comments on this?
> 
> Looks fine to me. Is this good to go into Emacs 27, or does it have to
> wait until the release is done?

Please push to emacs-27.

Is this change safe, or will we need another pretest to be sure?  I
thought we could next go straight to a release candidate.

Thanks.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-30 12:05     ` Eli Zaretskii
@ 2021-01-30 18:32       ` Riccardo Mottola
  2021-01-30 18:34         ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Riccardo Mottola @ 2021-01-30 18:32 UTC (permalink / raw)
  To: Eli Zaretskii, Alan Third; +Cc: 46036

Hi,


Eli Zaretskii wrote:
>>>> this code is guarded with MacOS 10.7, but the compiler doesn't like it.
>>>>
>>>> It is as easy to write it old-style:
>>>>     NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
>>>>
>>>> and emacs 27.1 happily running on Lion again.
>>> Alan, any comments on this?
>> Looks fine to me. Is this good to go into Emacs 27, or does it have to
>> wait until the release is done?
> Please push to emacs-27.
>
> Is this change safe, or will we need another pretest to be sure?  I
> thought we could next go straight to a release candidate.


to my knowledge it is safe: it is really equivalent code, the new syntax 
is just a shortcut. A test on a newer MacOS is of course needed, I don't 
have one.

Riccardo





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-30 18:32       ` Riccardo Mottola
@ 2021-01-30 18:34         ` Eli Zaretskii
  2021-01-30 22:15           ` Alan Third
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2021-01-30 18:34 UTC (permalink / raw)
  To: Riccardo Mottola; +Cc: alan, 46036

> Cc: 46036@debbugs.gnu.org
> From: Riccardo Mottola <riccardo.mottola@libero.it>
> Date: Sat, 30 Jan 2021 19:32:17 +0100
> 
> > Is this change safe, or will we need another pretest to be sure?  I
> > thought we could next go straight to a release candidate.
> 
> to my knowledge it is safe: it is really equivalent code, the new syntax 
> is just a shortcut. A test on a newer MacOS is of course needed, I don't 
> have one.

Thanks.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#46036: fails do build on macos 10.7
  2021-01-30 18:34         ` Eli Zaretskii
@ 2021-01-30 22:15           ` Alan Third
  0 siblings, 0 replies; 7+ messages in thread
From: Alan Third @ 2021-01-30 22:15 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 46036-done, Riccardo Mottola

On Sat, Jan 30, 2021 at 08:34:00PM +0200, Eli Zaretskii wrote:
> > Cc: 46036@debbugs.gnu.org
> > From: Riccardo Mottola <riccardo.mottola@libero.it>
> > Date: Sat, 30 Jan 2021 19:32:17 +0100
> > 
> > > Is this change safe, or will we need another pretest to be sure?  I
> > > thought we could next go straight to a release candidate.
> > 
> > to my knowledge it is safe: it is really equivalent code, the new syntax 
> > is just a shortcut. A test on a newer MacOS is of course needed, I don't 
> > have one.
> 
> Thanks.

I agree that it's safe so I've pushed the change.
-- 
Alan Third





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-01-30 22:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-22 14:57 bug#46036: fails do build on macos 10.7 Riccardo Mottola
2021-01-30  8:57 ` Eli Zaretskii
2021-01-30 10:56   ` Alan Third
2021-01-30 12:05     ` Eli Zaretskii
2021-01-30 18:32       ` Riccardo Mottola
2021-01-30 18:34         ` Eli Zaretskii
2021-01-30 22:15           ` Alan Third

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.