From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#15667: 24.3.50; ns-win.el -- keymap assignments for isearch-repeat-backward/forward. Date: Thu, 21 Jan 2021 21:47:04 +0000 Message-ID: References: <87a6t45nx1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Keith David Bershatsky , 15667@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 22:48:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2hoR-0003Kc-Hq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 22:48:19 +0100 Original-Received: from localhost ([::1]:47920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2hoQ-0007MF-Do for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 16:48:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2hoA-0007KL-OW for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:48:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2ho9-0001H1-Oi for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2ho9-0002wk-M9 for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15667 X-GNU-PR-Package: emacs Original-Received: via spool by 15667-submit@debbugs.gnu.org id=B15667.161126563811275 (code B ref 15667); Thu, 21 Jan 2021 21:48:01 +0000 Original-Received: (at 15667) by debbugs.gnu.org; 21 Jan 2021 21:47:18 +0000 Original-Received: from localhost ([127.0.0.1]:59587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2hnR-0002vn-Q8 for submit@debbugs.gnu.org; Thu, 21 Jan 2021 16:47:18 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:35937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2hnP-0002vX-AY for 15667@debbugs.gnu.org; Thu, 21 Jan 2021 16:47:16 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id D670560461; Thu, 21 Jan 2021 21:47:08 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1611265628; bh=6vbkJYXFvzNjouBylCPs7CT9NTYm7LdlrR9cDFu3GrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KzXlumhFDmcuB+TRXR/urR5O647nzt0CGqJOkvImO7vWH9PUmkc+aY/Y/aJmXi5gF 4K0v14Ih3d2cJuDTH2wB0ndulB0J5fVxy3UQILpUbS4M7NE73AolQ36aDLXJLn+o9W GIhnYvIn/OydotWWhZJx/zEtiaAZA0mjbJYIg8u8AJlJ/fGZim/xgPueYWMgjmeR06 wNgtRiATiDqRb2ifBxZUI7QCTZo9WRCBr3gKayky0F7cCU4GvKcykXr/stK7MnAicL eikI61MmBp6wVkVnBS4AxObTzpo0Nc1rMA7zZSseCRSOJeoFnvEepPhUi82WgSVBcB CCB57cRxraHqA== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 3E0CA2029F871B; Thu, 21 Jan 2021 21:47:04 +0000 (GMT) Mail-Followup-To: Alan Third , Lars Ingebrigtsen , Keith David Bershatsky , 15667@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <87a6t45nx1.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198350 Archived-At: On Wed, Jan 20, 2021 at 03:42:50AM +0100, Lars Ingebrigtsen wrote: > Keith David Bershatsky writes: > > > The global-map key assignments within ns-win.el for > > isearch-repeat-backward and isearch-repeat-forward are insufficient to > > achieve the behavior contemplated by the source code of isearch.el. > > Specifically, the isearch-mode terminates immediately after invoking > > the repeat functions and the sticky highlight of searches found does > > not automatically cleanup. Invoking these repeat functions should > > keep isearch-mode active, and then sticky highlight should > > automatically clean up when exiting the isearch (e.g., by pressing the > > return key after the search). The problem is corrected by the > > following keymap assignments, which mirrors the usage within the > > source code of isearch.el > > > > (define-key global-map [?\s-f] 'isearch-forward) > > (define-key esc-map [?\s-f] 'isearch-forward-regexp) > > (define-key minibuffer-local-isearch-map [?\s-f] 'isearch-forward-exit-minibuffer) > > (define-key isearch-mode-map [?\s-f] 'isearch-repeat-forward) > > > > (define-key global-map [?\s-F] 'isearch-backward) > > (define-key esc-map [?\s-F] 'isearch-backward-regexp) > > (define-key minibuffer-local-isearch-map [?\s-F] 'isearch-reverse-exit-minibuffer) > > (define-key isearch-mode-map [?\s-F] 'isearch-repeat-backward) > > (I'm going through old bug reports that unfortunately got no response at > the time.) > > I don't really use the Emacs on Macos much, but perhaps Alan has an > opinion here? Added to the CCs. I don't ever really use these macOS shortcuts, TBH. I've generally followed the rule that if it's replicating standard behaviour and it doesn't interfere with something else then it may as well go in. -- Alan Third