From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Help sought from C++ expert: is this `value' a type or something else (what)? Date: Sat, 21 Jan 2023 14:59:50 +0000 Message-ID: References: <87sfg68pf2.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?=D3scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 21 16:00:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJFMO-0008qZ-FW for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Jan 2023 16:00:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJFLZ-000785-J7; Sat, 21 Jan 2023 09:59:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFLY-00077m-EQ for emacs-devel@gnu.org; Sat, 21 Jan 2023 09:59:56 -0500 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFLW-0005lZ-9Y for emacs-devel@gnu.org; Sat, 21 Jan 2023 09:59:55 -0500 Original-Received: (qmail 17273 invoked by uid 3782); 21 Jan 2023 15:59:51 +0100 Original-Received: from acm.muc.de (p2e5d5259.dip0.t-ipconnect.de [46.93.82.89]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 21 Jan 2023 15:59:51 +0100 Original-Received: (qmail 7334 invoked by uid 1000); 21 Jan 2023 14:59:50 -0000 Content-Disposition: inline In-Reply-To: <87sfg68pf2.fsf@telefonica.net> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302593 Archived-At: Hello, Óscar. On Thu, Jan 19, 2023 at 17:22:41 +0100, Óscar Fuentes wrote: > Alan Mackenzie writes: > > Hello, Emacs. > > > > In the following test file, templates-9.cc from the CC Mode test suite, > > on the indicated line, what is the syntactic significance of `value'? > > Traditionally, it has fontified with the default face, but recently after > > some (not yet committed) changes in CC Mode, it has started getting > > font-lock-type-face. > > > > I don't understand the file at all, hardly, and can't work out whether > > the old (non-) fontification was correct, or whether the new > > fontification of f-l-type-face is correct. Help would be appreciated. > > > > Just as a matter of interest, in c++-ts-mode a treesit-query-error gets > > thrown. It isn't clear to me whether the file is still valid C++. > It is not valid C++ because it misses quite a few declarations. Yes. Michael Duggan has identified the file as part of an early boost source, and clearly there are bits missing. > The parser has no way of knowing what `value' is unless it can see the > relevant declarations. And even then, in the general case, it is not > possible to really know unless your "parser" is, actually, a C++ front > end. So both c++-mode and c++-ts-mode are out of their breadth here. c++-ts-mode is a little disappointing, here. It displays virtually everything (including "value") in font-lock-type-face. I've managed to track down the bug in my uncommitted CC Mode changes and fix it. > IMAO, a reasonable heuristic is to consider it a value unless it is > preceded by `typename'. Yes. That is the general consensus from all who answered me, so a big thank you to yourself and the other people! -- Alan Mackenzie (Nuremberg, Germany).