From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter: Where to Put C/C++ Stuff Date: Tue, 1 Nov 2022 12:10:46 +0000 Message-ID: References: <83r0yncf9a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17666"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Randy Taylor , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 01 13:12:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opq7z-0004O0-OR for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Nov 2022 13:12:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opq6x-0005Is-I0; Tue, 01 Nov 2022 08:11:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opq6i-000533-Pe for emacs-devel@gnu.org; Tue, 01 Nov 2022 08:11:05 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opq6g-0007gx-LJ for emacs-devel@gnu.org; Tue, 01 Nov 2022 08:11:04 -0400 Original-Received: (qmail 29956 invoked by uid 3782); 1 Nov 2022 13:10:47 +0100 Original-Received: from acm.muc.de (p4fe15c46.dip0.t-ipconnect.de [79.225.92.70]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 01 Nov 2022 13:10:47 +0100 Original-Received: (qmail 4301 invoked by uid 1000); 1 Nov 2022 12:10:46 -0000 Content-Disposition: inline In-Reply-To: <83r0yncf9a.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298932 Archived-At: Hello, Eli. On Tue, Nov 01, 2022 at 09:20:33 +0200, Eli Zaretskii wrote: > > Date: Tue, 01 Nov 2022 02:30:54 +0000 > > From: Randy Taylor > > Where specifically should the C and C++ tree-sitter stuff go? I've been using it for a couple months and would > > like to upstream syntax highlighting for both. I'll focus on getting C done first. > > I see there are a lot of cc- files; would it be appropriate to add the tree-sitter stuff into a new cc-treesit.el file? > I suggest a separate cc-*.el file (e.g., cc-treesit.el), and some user > option to trigger its use instead of (or maybe in addition to, as the > case may be) the equivalent CC mode stuff. > Alan, are you okay with this approach? Yes, certainly. It is the approach I would have chosen myself. The key sequence C-c C-t is currently unused in CC Mode, and it would seem ideal to toggle tree-sitter with. -- Alan Mackenzie (Nuremberg, Germany).