From: Alan Third <alan@idiocy.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Zajcev Evgeny <zevlg@yandex.ru>, emacs-devel@gnu.org
Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property
Date: Sat, 12 Dec 2020 23:59:23 +0000 [thread overview]
Message-ID: <X9VZW71WGkx66lES@breton.holly.idiocy.org> (raw)
In-Reply-To: <87h7oq7iiz.fsf@gnus.org>
On Sat, Dec 12, 2020 at 11:43:00PM +0100, Lars Ingebrigtsen wrote:
> With this change, I get
>
> (emacs:3509529): librsvg-CRITICAL **: 23:41:23.634: rsvg_handle_set_dpi_x_y: assertion 'is_rsvg_handle(handle)' failed
>
> on some SVG images (example included below).
Sorry, that was my fault, caused by another commit. I put the setting
of DPI before the check for whether the SVG file loaded, so when it
failed (as that image does) it tried to use the rsvg_handle anyway.
I've moved the DPI code to after the check and the image fails
silently now, the same as before.
--
Alan Third
next prev parent reply other threads:[~2020-12-12 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201212124845.19694.69782@vcs0.savannah.gnu.org>
[not found] ` <20201212124847.8879221335@vcs0.savannah.gnu.org>
2020-12-12 22:43 ` master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Lars Ingebrigtsen
2020-12-12 23:59 ` Alan Third [this message]
2020-12-13 12:53 ` Lars Ingebrigtsen
[not found] <mailman.1938.1607798832.19112.emacs-diffs@gnu.org>
2020-12-12 19:42 ` Eli Zaretskii
2020-12-12 20:42 ` Evgeny Zajcev
2020-12-13 15:05 ` Eli Zaretskii
2020-12-16 22:08 ` Evgeny Zajcev
2020-12-19 10:09 ` Eli Zaretskii
2020-12-19 12:24 ` Evgeny Zajcev
2020-12-26 9:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9VZW71WGkx66lES@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=zevlg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.