From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Loading svg from memory using custom filename for base_uri Date: Thu, 3 Dec 2020 19:57:35 +0000 Message-ID: References: <9684BD96-2E4E-45E1-92CC-69306A7C3205@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13201"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel To: Evgeny Zajcev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 03 20:58:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkukQ-0003Ks-Jz for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Dec 2020 20:58:38 +0100 Original-Received: from localhost ([::1]:52304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkukP-0006FD-IS for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Dec 2020 14:58:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkujZ-0005UU-Ru for emacs-devel@gnu.org; Thu, 03 Dec 2020 14:57:45 -0500 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:2d:8::218]:35217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkujW-0004fe-8m; Thu, 03 Dec 2020 14:57:45 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id C947B601C4; Thu, 3 Dec 2020 19:57:38 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A352F202855CD5; Thu, 3 Dec 2020 19:57:35 +0000 (GMT) Mail-Followup-To: Alan Third , Evgeny Zajcev , Eli Zaretskii , emacs-devel Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a01:4f8:fff0:2d:8::218; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260236 Archived-At: On Thu, Dec 03, 2020 at 08:50:15PM +0300, Evgeny Zajcev wrote: > > Here is updated patch, with support for `:base-uri` for :file image spec as > well It looks good to me. There are two things I think we need. One is to add an entry for :base-uri to the svg_format array in image.c, and some documentation, if you fancy writing it? Do we also need an entry in NEWS for this? -- Alan Third