bug#44901: 28.0.50; dired-compress-file: provide customization for compressing command

bug#44901: 28.0.50; dired-compress-file: provide customization for compressing command

[Jean Louis]

In the function: dired-compress-file there is hard coded gzip as
compressor:

(dired-check-process (concat "Compressing " file)
                        "gzip" "-f" file))

It would be useful to have customization as there are various other
compressors that are often used to distribute files such as these, and
all of them supprot -f option:

- bzip2
- xz
- lzip
- there may be others

Customization option could be called dired-compress-command or
similar and it could default to gzip 

(defcustom dired-compress-command "gzip"
  "Default compressing command for dired. The commpressing 
command shall support the option `-f' to force overwriting the file"
  :type 'string
  :group 'dired)

Then the part here in the function `dired-compress-file' can be changed to:

(dired-check-process (concat "Compressing " file)
                        dired-compress-command "-f" file))


Thanks,
Jean Louis
⎔ λ 🄯 𝍄 𝌡 𝌚

bug#44901: 28.0.50; dired-compress-file: provide customization for compressing command

[Jean Louis]

Additionally this variable should be updated:

(defvar dired-compress-files-alist
  '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
    ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
    ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
    ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
    ("\\.zip\\'" . "zip %o -r --filesync %i"))

to be:

(defvar dired-compress-files-alist
  '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
    ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
    ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
    ("\\.tar\\.lz\\'" . "tar -cf - %i | lzip -c9 > %o") ;; new line for lzip
    ("\\.tar\\.lzo\\'" . "tar -cf - %i | lzop -c9 > %o") ;; new line for lzop
    ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
    ("\\.zip\\'" . "zip %o -r --filesync %i"))

Updating that function with those compressors is useful and related
this wish to have "gzip" also customizable. As dired-x supports
decompressing various files but user have no possibility to customize
the compressor command.

There are also pbzip2, pigz, pixz, pixz that offer parallel
compression that could be included in future.

bug#44901: 28.0.50; dired-compress-file: provide customization for compressing command

[Lars Ingebrigtsen]

Jean Louis <bugs@gnu.support> writes:

> Additionally this variable should be updated:
>
> (defvar dired-compress-files-alist
>   '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
>     ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
>     ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
>     ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
>     ("\\.zip\\'" . "zip %o -r --filesync %i"))
>
> to be:
>
> (defvar dired-compress-files-alist
>   '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
>     ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
>     ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
>     ("\\.tar\\.lz\\'" . "tar -cf - %i | lzip -c9 > %o") ;; new line for lzip
>     ("\\.tar\\.lzo\\'" . "tar -cf - %i | lzop -c9 > %o") ;; new line for lzop
>     ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
>     ("\\.zip\\'" . "zip %o -r --filesync %i"))

Makes sense; I've now pushed this to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44901: 28.0.50; dired-compress-file: provide customization for compressing command

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Jean Louis <bugs@gnu.support> writes:
>
>> Additionally this variable should be updated:
>>
>> (defvar dired-compress-files-alist
>>   '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
>>     ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
>>     ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
>>     ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
>>     ("\\.zip\\'" . "zip %o -r --filesync %i"))
>>
>> to be:
>>
>> (defvar dired-compress-files-alist
>>   '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o")
>>     ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o")
>>     ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o")
>>     ("\\.tar\\.lz\\'" . "tar -cf - %i | lzip -c9 > %o") ;; new line for lzip
>>     ("\\.tar\\.lzo\\'" . "tar -cf - %i | lzop -c9 > %o") ;; new line for lzop
>>     ("\\.tar\\.zst\\'" . "tar -cf - %i | zstd -19 -o %o")
>>     ("\\.zip\\'" . "zip %o -r --filesync %i"))
>
> Makes sense; I've now pushed this to Emacs 28.

It seems like this was fixed, so I'm closing this bug report.