From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Fri, 6 Nov 2020 00:36:40 +0300 Message-ID: References: <20201104161200.tyeo2r5jibdahukb@Ergus> <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> <20201105210915.3rl3z6jngsrzgbwv@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12675"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/+ (1036f0e) (2020-10-18) Cc: Ergus , Manuel Uberti , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 22:40:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kamzv-0003Ar-6w for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 22:40:47 +0100 Original-Received: from localhost ([::1]:53758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kamzu-0003Y7-7P for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 16:40:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamyd-0002KI-AH for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:39:27 -0500 Original-Received: from static.rcdrun.com ([95.85.24.50]:55821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamyb-0007XD-Um for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:39:27 -0500 Original-Received: from localhost ([::ffff:197.157.0.43]) (AUTH: PLAIN admin, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by static.rcdrun.com with ESMTPSA id 00000000002C0006.000000005FA4710C.0000053B; Thu, 05 Nov 2020 21:39:23 +0000 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=95.85.24.50; envelope-from=bugs@gnu.support; helo=static.rcdrun.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 08:59:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258761 Archived-At: * Gregory Heytings [2020-11-06 00:19]: > > > > As I said earlier in this thread, you can have icomplete-vertical > > > without using that branch, with the master branch you only need to > > > `(setq icomplete-separator "\n")'. > > > > > > If you want a more robust solution however (neither the above nor > > > the branch are always correct), > > > > In which case the branch is not correct? > > > > This has been discussed at length earlier: it is in practice impossible to > calculate the height of the minibuffer, and to calculate the size of the > completion candidates list to insert in the minibuffer. Yet you need to do > both to have a correct solution with the approach of the branch. While this may not be mathematically possible, it can be observed that ivy simply works much better then both the reinvented icomplete-mode and built-in ido-mode.