From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 5 Nov 2020 13:05:30 +0300 Message-ID: References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/+ (1036f0e) (2020-10-18) Cc: Ergus , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 15:04:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kafs5-0005e0-7V for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 15:04:13 +0100 Original-Received: from localhost ([::1]:58312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kafs4-0003sR-8N for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 09:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kafoK-0007k6-OU for emacs-devel@gnu.org; Thu, 05 Nov 2020 09:00:20 -0500 Original-Received: from static.rcdrun.com ([95.85.24.50]:58553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kafoI-0001Vw-Qc for emacs-devel@gnu.org; Thu, 05 Nov 2020 09:00:20 -0500 Original-Received: from localhost ([::ffff:197.157.0.43]) (AUTH: PLAIN admin, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by static.rcdrun.com with ESMTPSA id 00000000002A1235.000000005FA40570.00003619; Thu, 05 Nov 2020 14:00:15 +0000 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=95.85.24.50; envelope-from=bugs@gnu.support; helo=static.rcdrun.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 08:59:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258723 Archived-At: * Gregory Heytings via "Emacs development discussions. [2020-11-05 11:37]: > > Hi Ergus, > > > > > The icomplete-vertical feature branch is pretty much ready, please if > > any maintainer could give it a last review and tell me anything else > > needed to merge into master? > > > > You may have followed the (heated) discussions about displaying completion > candidates vertically in the minibuffer about a month ago. Short summary: > > 1. During these discussions, Eli added two lines in xdisp.c, and > icomplete-vertical now only requires `(setq icomplete-separator > "\n")'. I hope that functions are made in the spirit of ivy and helm so that I can build completion based system for any choices, not only minibuffer built-in choices. For ivy, I have this: ivy-completing-read is an autoloaded compiled Lisp function in ‘ivy.el’. (ivy-completing-read PROMPT COLLECTION &optional PREDICATE REQUIRE-MATCH INITIAL-INPUT HISTORY DEF INHERIT-INPUT-METHOD) icomplete-vertical would be very useful function and I hope it will get: - full window support, like poping out of minibuffer to full window - settable size of minibuffer - actions like ivy with M-o or helm with TAB Then I could develop on built-in Emacs features instead of asking for too many outside packages to be loaded. Let me know how to get that branch, that I can test it. Jean