From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Wed, 30 Dec 2020 12:46:52 +0000 Message-ID: References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> <99CD03DA-DF1F-4C2C-A2FA-DFD7DF3B2750@acm.org> <0F1B9914-2668-4775-822A-49A36D4A9F3F@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6978"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 13:48:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuau0-0001i5-El for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 13:48:32 +0100 Original-Received: from localhost ([::1]:39394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuatz-0003Ma-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 07:48:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuatX-0003MR-1k for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 07:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuatW-0007zr-FD for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 07:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuatW-0003jS-Ct for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 07:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160933242414278 (code B ref 45502); Wed, 30 Dec 2020 12:48:02 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 30 Dec 2020 12:47:04 +0000 Original-Received: from localhost ([127.0.0.1]:42113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuasa-0003iD-2Y for submit@debbugs.gnu.org; Wed, 30 Dec 2020 07:47:04 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:45775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuasX-0003hj-U2 for 45502@debbugs.gnu.org; Wed, 30 Dec 2020 07:47:02 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 20CBE6008F; Wed, 30 Dec 2020 12:46:55 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1609332414; bh=pTVXoczdgQSl+VlkqT1QUvPVZ7w8KfXzr39+pw9YO2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+YgsVPHPqYVHHuRYEbubCNI6mhvkGH2jAsnRbN09S8XsLcFqkU2HXRsKjRIbwdyW A+p8hlqnx3zVUZcAyyQOQgbMKLV6eHxjUvpB+adL6JlVb6AxTUYKjwGaiAmm9qxExh GxqCkK4Y5NFLrJDFGLDarmiptddH9WEkFST7cruRx6IlX2QHg35IeoIocr+9407he0 vvtzPWYVIMNj7iF7qc85MkO4WkRW+o0a6FsZp2Ti8Cptmv5U+H+/8D9iW1j30jVb/C Jsw6e9kqEA/DP1Y8WdIA8w4H6BVwRRyf7Ka9oPTwWVHv/Z22+g6If2lj/FC3agVBEM 9jAB0M+YriEIQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 8BE2A202956C9A; Wed, 30 Dec 2020 12:46:52 +0000 (GMT) Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Content-Disposition: inline In-Reply-To: <0F1B9914-2668-4775-822A-49A36D4A9F3F@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197023 Archived-At: On Wed, Dec 30, 2020 at 01:19:48PM +0100, Mattias Engdegård wrote: > 30 dec. 2020 kl. 00.49 skrev Alan Third : > > (By the way, 'chording' isn't quite the same as a multi-key > sequence; chords are rather simultaneous presses, like C-M-x, no? To > continue a musical metaphor, perhaps an Emacs key sequence is an > arpeggio?) Good point. I thought about it for a while and wasn't really sure what to write, so my comment wasn't very good even ignoring that. :) > Here is a slightly less ugly variant of the symbol substitution > patch. Maybe we should apply it and see if there are any complaints, > or if we turn against it ourselves later on? It looks good to me, so I see no reason not to apply it and see if anyone complains. Oh, I noticed that the Mark menu in dired has the Help menu search entry. I guess I've missed something somewhere. I wondered if that was set somewhere but couldn't see any reference to it so assumed macOS was doing something clever when it saw a "Help" top level submenu... BTW, this isn't a comment on your code, I'm just curious. I notice you use C functions within Obj C classes where I would probably have just created another method. Is that just because they're dealing with C code exclusively or something else? -- Alan Third