From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 45502@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries
Date: Tue, 29 Dec 2020 13:53:55 +0000 [thread overview]
Message-ID: <X+s08yRWYNi433Du@breton.holly.idiocy.org> (raw)
In-Reply-To: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org>
On Tue, Dec 29, 2020 at 01:02:21PM +0100, Mattias Engdegård wrote:
> 28 dec. 2020 kl. 19.36 skrev Alan Third <alan@idiocy.org>:
>
> > I'm not sure either, but I guess the tabstop thing would look
> > something like: [...]
>
> Actually seems to work! (In your place I would feign a complete lack
> of surprise.)
No feigning required. 😉
> Resulting patch attached.
Looks good. As I understand it GNUstep doesn't need this fix, so
please make it Cocoa only.
> 28 dec. 2020 kl. 23.46 skrev Daniel Martín <mardani29@yahoo.es>:
>
> > Thanks for the patch! It crashed Emacs when I tried to open the Gnus
> > menu bar (the Gnus menu bar is an extreme case with lots of bindings).
>
> Confirmed, but that is unrelated to my patch. Alan, will you have a look?
There was a work-around for some problem related to waiting_for_input
in the old menu code that was lost when I copied the code from
xmenu.c, so I've put it back in and pushed to master. It looks like it
fixes the crash here.
> > I'm not sure if left-alignment or right-alignment would be better. To
> > improve visuals, Apple seems to align with respect to the ⌘ symbol, but
> > that doesn't fit Emacs well because there's no single modifier that is
> > used in almost every keybinding (some use Control, some Meta). Also,
> > it's not uncommon in Emacs to have keybindings that are a couple of
> > keymaps deep.
>
> Right; it's easy to use either left or right alignment for the
> bindings. (I think we all agree that they should be kept in a
> separate column to the right of the menu strings in either case.)
> I'm going to experiment with translating modifiers and keys to the
> standard symbols. Not sure how to deal with modifiers that are
> unavailable, such as s-k when no Super modifier is available.
There's also the problem that we allow setting the left and right
modifiers separately, so option or command may not match both keys.
--
Alan Third
next prev parent reply other threads:[~2020-12-29 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 14:23 bug#45502: [PATCH] Prettier key bindings in NS menu entries Mattias Engdegård
2020-12-28 18:36 ` Alan Third
2020-12-29 12:02 ` Mattias Engdegård
2020-12-29 13:53 ` Alan Third [this message]
2020-12-29 14:41 ` Mattias Engdegård
2020-12-29 15:50 ` Alan Third
2020-12-29 17:34 ` Mattias Engdegård
2020-12-29 21:24 ` Alan Third
2020-12-29 22:53 ` Mattias Engdegård
2020-12-29 23:49 ` Alan Third
2020-12-30 12:19 ` Mattias Engdegård
2020-12-30 12:46 ` Alan Third
2020-12-30 13:09 ` Alan Third
2020-12-30 15:53 ` Mattias Engdegård
2020-12-30 13:12 ` Mattias Engdegård
2020-12-28 22:46 ` Unknown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+s08yRWYNi433Du@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=45502@debbugs.gnu.org \
--cc=mardani29@yahoo.es \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.