From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#44333: 27.1; macOS menu bar 2-clicks Date: Fri, 25 Dec 2020 17:26:49 +0000 Message-ID: References: <2B2932BB-DFD0-409C-9351-FACEC46927BB@acm.org> <20201031150101.GN59267@breton.holly.idiocy.org> <6F053CD0-A164-490F-9D15-225D8782C633@acm.org> <20201101172843.GQ59267@breton.holly.idiocy.org> <40B4784A-74FF-4021-B51C-2E80801483BE@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13649"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44333@debbugs.gnu.org, Viktor Kharitonovich To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 25 18:29:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksqti-0003RF-VE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 18:29:03 +0100 Original-Received: from localhost ([::1]:40682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksqti-0006ZN-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 12:29:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksqsk-00068n-Sr for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 12:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksqsk-00059X-Lp for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 12:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ksqsk-0003OF-Hm for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 12:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2020 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44333 X-GNU-PR-Package: emacs Original-Received: via spool by 44333-submit@debbugs.gnu.org id=B44333.160891722212948 (code B ref 44333); Fri, 25 Dec 2020 17:28:02 +0000 Original-Received: (at 44333) by debbugs.gnu.org; 25 Dec 2020 17:27:02 +0000 Original-Received: from localhost ([127.0.0.1]:58117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksqrm-0003Mb-7r for submit@debbugs.gnu.org; Fri, 25 Dec 2020 12:27:02 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:34585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksqrj-0003MG-GN for 44333@debbugs.gnu.org; Fri, 25 Dec 2020 12:27:00 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 79A20600E9; Fri, 25 Dec 2020 17:26:53 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1608917212; bh=E4+A23wZDmpLvkeq/46BA8EPvvKktZ+FzGH+iFUjSss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L+vslsD3O4Gmh6RM+3aomujG/9V/waNnYIuqWRF/tjBoHEJMQ4Tx0Vfc5ketmk7Qc +v59EEoyw0pZCsClk2YXz1Wf1OVpTy/kIimLvdL8WF2mhy42HZv9ByNu39CO7e98Bv pzj+FQAB+V9XbwcmRqmXSwkttdmMqvNPw4jXNRLfDyduySCOfi/+ZRqk6/kU0SC81L ShGMeNgEENTxjk0nh/YPwLhK+XpegxhPGWd1NKSzI068WZ0FyH173jLUUhLfdowD2V XLmVdbBiBT9hNmc45ab65vKg1PT2nhEP8ap3N/8Xykpl+QhU6XVi3erObfskVNn0Vc iiOxTyIynizBA== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 8ABD7202927D12; Fri, 25 Dec 2020 17:26:49 +0000 (GMT) Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 44333@debbugs.gnu.org, Viktor Kharitonovich Content-Disposition: inline In-Reply-To: <40B4784A-74FF-4021-B51C-2E80801483BE@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196710 Archived-At: On Fri, Dec 25, 2020 at 05:06:15PM +0100, Mattias Engdegård wrote: > 23 dec. 2020 kl. 21.33 skrev Alan Third : > > > OK, I've had a go at this and tried removing EVERYTHING related to the > > delayed menu stuff and, as you say, it seems fine, but I barely ever > > use the menus, so I could be missing something. > > Thank you, I tried exactly the same thing. While it works, there are > annoying delays in dropping down the menus -- sometimes they come > down immediately, but more often than not I get a delay of 100-300 > ms. Do you experience them too? > > In any case, it's a lot better than the previous double-clutch > menus. I rarely use the menus either but partly because they were so > annoying; I find them useful for discovering functionality and keys > in packages. Getting rid of the delays would be nice, though. I don't see how the delays can be new as the menus would have to be recalculated under the old code anyway... It is quite noticeable, though... I notice this in the Apple docs[1]: If populating the menu will take a long time, implement numberOfItemsInMenu: and menu:updateItem:atIndex:shouldCancel: instead. I wonder if that's possible for us. ns_update_menubar is a big, complicated function that I've not been over in depth to work out what it's doing, so I don't know if it would be practical to break it up like I suspect using those two methods would require. > > For the record, the menu code (or maybe it's the toolbar, but I > > suspect the menus) kills GNUstep builds stone dead as soon as you try > > typing anything. It looks from the debugger like Emacs is still > > running, but it just won't update the screen. Turning off the menus > > appears to fix it. > > Maybe we could make the change conditional on GNUstep? Sorry, I was unclear. This is an older problem. I'm not sure when it was introduced. [1] https://developer.apple.com/documentation/appkit/nsmenudelegate/1518235-menuneedsupdate?language=objc -- Alan Third