From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#44333: 27.1; macOS menu bar 2-clicks Date: Fri, 25 Dec 2020 19:20:23 +0000 Message-ID: References: <2B2932BB-DFD0-409C-9351-FACEC46927BB@acm.org> <20201031150101.GN59267@breton.holly.idiocy.org> <6F053CD0-A164-490F-9D15-225D8782C633@acm.org> <20201101172843.GQ59267@breton.holly.idiocy.org> <40B4784A-74FF-4021-B51C-2E80801483BE@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27020"; mail-complaints-to="usenet@ciao.gmane.io" To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 44333@debbugs.gnu.org, Viktor Kharitonovich Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 25 20:21:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksseE-0006rE-RS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 20:21:13 +0100 Original-Received: from localhost ([::1]:36142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksseD-00009v-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 14:21:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksse6-00009p-GY for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 14:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksse6-0001mY-8G for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 14:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ksse6-0005zC-3W for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 14:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2020 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44333 X-GNU-PR-Package: emacs Original-Received: via spool by 44333-submit@debbugs.gnu.org id=B44333.160892404122966 (code B ref 44333); Fri, 25 Dec 2020 19:21:02 +0000 Original-Received: (at 44333) by debbugs.gnu.org; 25 Dec 2020 19:20:41 +0000 Original-Received: from localhost ([127.0.0.1]:58148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kssdk-0005yM-QQ for submit@debbugs.gnu.org; Fri, 25 Dec 2020 14:20:41 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:59281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kssdg-0005y5-NX for 44333@debbugs.gnu.org; Fri, 25 Dec 2020 14:20:39 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id D47C5600E9; Fri, 25 Dec 2020 19:20:29 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1608924028; bh=dLK2ijF55FGJxg4KORQOfBWoBt2UhSs4Zr2W//gUgXk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=pqoQhl45rr5ijnZoAMmRl8cNvp8arCX7v75oehPc71XilrnRVlbZ3bpTIQQveu/Ea tEIBfxlcN1z4V9Gj9XBAOcsfd9z+IXUNA15/pCV/bgOtKQSytU3eL/XnIVct2qs2V6 47JU/UCOszjNN/ZQJtZustCMzo5Cv2DB28r7lB2FDDeCsOCm0kf8o9qsL9ITnr+oPh KB2J//G0ABcbLw4uDwvkOWkPp9ngrdXBZ860TSdwPwT973tVuuNxj4PkBDAsggcWbd Ic/jfpVpydjBmI6y4TjGMij6Xf5FRD36Ku9bfrOqAPm26B2AEXQEn/HqLVxnqOEcCx nQZ0+CV7SCkSQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id ED4AC20292B579; Fri, 25 Dec 2020 19:20:23 +0000 (GMT) Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 44333@debbugs.gnu.org, Viktor Kharitonovich Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196711 Archived-At: On Fri, Dec 25, 2020 at 05:26:49PM +0000, Alan Third wrote: > ns_update_menubar is a big, complicated function that I've not been > over in depth to work out what it's doing, so I don't know if it > would be practical to break it up like I suspect using those two > methods would require. I've had a look through it, and I've noticed that most of the work appears to be building a tree of widget_value structs. A quick look at xmenu.c and w32menu.c leaves me with the impression that they have almost identical code for that part, but for some reason the NS port is different (and is full of "FIXME: this is broken" comments). So I suppose the first thing to do should be to align the NS code with the other terminals, and see if that improves things. -- Alan Third