From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>,
44333@debbugs.gnu.org,
"Viktor Kharitonovich" <viktor.kharitonovich@gmail.com>
Subject: bug#44333: 27.1; macOS menu bar 2-clicks
Date: Fri, 25 Dec 2020 19:20:23 +0000 [thread overview]
Message-ID: <X+Y7d2co3tjJmog2@breton.holly.idiocy.org> (raw)
In-Reply-To: <X+Yg2S1k6HVBx2o2@breton.holly.idiocy.org>
On Fri, Dec 25, 2020 at 05:26:49PM +0000, Alan Third wrote:
> ns_update_menubar is a big, complicated function that I've not been
> over in depth to work out what it's doing, so I don't know if it
> would be practical to break it up like I suspect using those two
> methods would require.
I've had a look through it, and I've noticed that most of the work
appears to be building a tree of widget_value structs. A quick look at
xmenu.c and w32menu.c leaves me with the impression that they have
almost identical code for that part, but for some reason the NS port
is different (and is full of "FIXME: this is broken" comments).
So I suppose the first thing to do should be to align the NS code with
the other terminals, and see if that improves things.
--
Alan Third
next prev parent reply other threads:[~2020-12-25 19:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 17:53 bug#44333: 27.1; macOS menu bar 2-clicks Viktor Kharitonovich
2020-10-30 22:42 ` Alan Third
2020-10-31 14:08 ` Mattias Engdegård
2020-10-31 15:01 ` Alan Third
2020-11-01 10:50 ` Mattias Engdegård
2020-11-01 17:28 ` Alan Third
2020-12-23 20:33 ` Alan Third
2020-12-25 16:06 ` Mattias Engdegård
2020-12-25 17:26 ` Alan Third
2020-12-25 19:20 ` Alan Third [this message]
2020-12-25 22:28 ` Mattias Engdegård
2020-12-26 17:07 ` Alan Third
2020-12-26 17:42 ` Mattias Engdegård
2020-12-26 21:52 ` Alan Third
2020-12-27 16:56 ` Alan Third
2020-12-27 17:14 ` Mattias Engdegård
2020-12-27 18:21 ` NS port menus (was: bug#44333: 27.1; macOS menu bar 2-clicks) Alan Third
2020-12-28 17:38 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+Y7d2co3tjJmog2@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=44333@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=viktor.kharitonovich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.