From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: A tip: how to display longer function names in profiler-report Date: Tue, 22 Dec 2020 12:22:04 +0000 Message-ID: References: <63c6196a-319b-f436-4f8f-14b6719f90de@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , =?iso-8859-1?Q?Cl=E9ment?= Pit-Claudel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 22 13:22:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krggs-0006Xa-Om for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Dec 2020 13:22:58 +0100 Original-Received: from localhost ([::1]:42550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krggr-0001cl-R6 for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Dec 2020 07:22:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krgg5-0000wP-0N for emacs-devel@gnu.org; Tue, 22 Dec 2020 07:22:09 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:45193 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1krgg3-0007GX-1o for emacs-devel@gnu.org; Tue, 22 Dec 2020 07:22:08 -0500 Original-Received: (qmail 71482 invoked by uid 3782); 22 Dec 2020 12:22:04 -0000 Original-Received: from acm.muc.de (p4fe15aec.dip0.t-ipconnect.de [79.225.90.236]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Tue, 22 Dec 2020 13:22:04 +0100 Original-Received: (qmail 5837 invoked by uid 1000); 22 Dec 2020 12:22:04 -0000 Content-Disposition: inline In-Reply-To: <63c6196a-319b-f436-4f8f-14b6719f90de@gmail.com> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261480 Archived-At: Hello, Eli and Clément. On Mon, Dec 21, 2020 at 16:34:10 -0500, Clément Pit-Claudel wrote: > On 12/21/20 4:24 PM, Alan Mackenzie wrote: > > Something like, very roughly: .... > Precisely :) Love it. And we can even remove the padding spaces from the last column. The padding has now gone. Function names are now never truncated by the profiler. The only truncation that can happen is when the user's window is too narrow, something easily remedied. This change (putting the usage figures on the left, and the function names on the right) seems such a clear improvement, that I've taken the liberty of just committing it (including NEWS item and amendments to debugging.texi). The commit hash is 9920929e7b. In the event that there are any objections, it would be an easy commit to reverse. -- Alan Mackenzie (Nuremberg, Germany).